Accept object for label orientation #1247
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1234.
This is what it looks like in the demo:
The labels with "bottom" also overlap with the chart when labelOrientation is just "bottom", so this isn't directly related to my changes. Dunno if that's something you want me to fix here or if you have an issue for that.
I had to extract
getLabelOrientation
cuz ESLint was complaining about function complexity. Also wondering the props types are in "style". Dunno if we should provide a default fallback if people leave out a specific label's orientation? This seemed like the least-invasive implementation though.