Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor jest configuration #2793

Closed
wants to merge 0 commits into from
Closed

Refactor jest configuration #2793

wants to merge 0 commits into from

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Feb 8, 2024

Refactor the jest configuration to avoid cyclic dependencies in packages and support Windows platforms for running jest.

  • Upgrades Jest to the latest version 29+
  • Adds jest config shells to every package. This avoids problems with paths so all configs are now relative to the package itself
  • Removes jests from wireit and package scripts. It now runs with plain vanilla jest commands
  • Use typescript for jest configurations
  • Removes all circular devDependencies from all packages package.json files
  • Fixes all test imports so they are relative to the file (./chart.ts) instead of virtual (victory-charts)
  • Removes the test/node/victory.test.js as that functionality is tested in packages/victory as a snapshot.
  • Removes victory-native from the tsconfig sync script, it has a custom config now

Testing Steps

$ pnpm i
$ pnpm clean:cache
$ pnpm clean:build
$ pnpm build
$ pnpm jest

Copy link

changeset-bot bot commented Feb 8, 2024

⚠️ No Changeset found

Latest commit: 9faad13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 4:49pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant