Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Angular 17 #416

Closed
SupremeVoid opened this issue Nov 8, 2023 · 3 comments · Fixed by #417
Closed

Support Angular 17 #416

SupremeVoid opened this issue Nov 8, 2023 · 3 comments · Fixed by #417

Comments

@SupremeVoid
Copy link

Support Angular 17.

Peer Dependencies in package.json currently requires Angular 16.
@devoto13
Copy link
Collaborator

devoto13 commented Nov 8, 2023

Will cut a release later today.

@SupremeVoid
Copy link
Author

I wanted to open a pull request (updating all dev-/dependencies) but there are problems with the eslint configuration.
Something broke the configuration.

 0:0  error  Parsing error: ESLint was configured to run on `<tsconfigRootDir>/projects/demo/src/environments/environment.prod.ts` using `parserOptions.project`:
- <tsconfigRootDir>/projects/demo/tsconfig.app.json
- <tsconfigRootDir>/projects/demo/tsconfig.spec.json
- <tsconfigRootDir>/projects/demo/e2e/tsconfig.json
However, none of those TSConfigs include this file. Either:
- Change ESLint's list of included files to not include this file
- Change one of those TSConfigs to include this file
- Create a new TSConfig that includes this file and include it in your parserOptions.project
See the typescript-eslint docs for more info: https://typescript-eslint.io/linting/troubleshooting#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file

devoto13 added a commit to devoto13/angular-fontawesome that referenced this issue Nov 8, 2023
@devoto13
Upgrade to Angular 17
afc17fe 
Fixes FortAwesome#416 FortAwesome#410
@devoto13 devoto13 mentioned this issue Nov 8, 2023
Merged
devoto13 added a commit to devoto13/angular-fontawesome that referenced this issue Nov 8, 2023
@devoto13
Upgrade to Angular 17
e3b5a30 
Fixes FortAwesome#416 FortAwesome#410
devoto13 added a commit to devoto13/angular-fontawesome that referenced this issue Nov 8, 2023
@devoto13
Upgrade to Angular 17
1a8401d 
Fixes FortAwesome#416 FortAwesome#410
@devoto13
Copy link
Collaborator

devoto13 commented Nov 8, 2023

Yeah, turns out it is a bit more involved than just updating the dependencies 🙃

devoto13 added a commit that referenced this issue Nov 8, 2023
@devoto13
Upgrade to Angular 17
547042a 
Fixes #416 #410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to Angular 17 devoto13/angular-fontawesome
2 participants
@devoto13 @SupremeVoid