Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update core to 1.2.32 and add support for titleId #397

Merged
merged 3 commits into from
Dec 22, 2020
Merged

update core to 1.2.32 and add support for titleId #397

merged 3 commits into from
Dec 22, 2020

Conversation

isidrok
Copy link
Contributor

@isidrok isidrok commented Dec 1, 2020

Update @fortawesome/fontawesome-svg-core to version 1.2.32 and add support for the titleId property in order to be able to use stable ids that can be replicated avoiding mismatches between SSR and client hydration.

Closes #337

@robmadole robmadole merged commit 14096ee into FortAwesome:master Dec 22, 2020
@robmadole
Copy link
Member

Thanks @isidrok !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data-fa-title-id prop is not working on FortAwesomeIcon
2 participants