Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing if-statement for "useRunningStatus", causing a bug with a midi device #134

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added missing if-statement for "useRunningStatus", causing a bug with a midi device #134

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f905cba
Update MIDI.hpp
luckyspacetraveller Nov 25, 2019
de8e227
Update MIDI.hpp
luckyspacetraveller Nov 25, 2019
8ebdf34
Merge branch 'master' of https://github.com/luckyspacetraveller/ardui…
luckyspacetraveller Nov 25, 2019
8944099
aligned code
luckyspacetraveller Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 24 additions & 15 deletions src/MIDI.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,24 +911,33 @@ bool MidiInterface<SerialPort, Settings>::parse()
mMessage.valid = true;

// Activate running status (if enabled for the received type)
switch (mMessage.type)
{
case NoteOff:
case NoteOn:
case AfterTouchPoly:
case ControlChange:
case ProgramChange:
case AfterTouchChannel:
case PitchBend:
// Running status enabled: store it from received message
mRunningStatus_RX = mPendingMessage[0];
break;
if (Settings::UseRunningStatus) {

default:
switch (mMessage.type)
{
case NoteOff:
case NoteOn:
case AfterTouchPoly:
case ControlChange:
case ProgramChange:
case AfterTouchChannel:
case PitchBend:
// Running status enabled: store it from received message
mRunningStatus_RX = mPendingMessage[0];
break;

default:
// No running status
mRunningStatus_RX = InvalidType;
break;
mRunningStatus_RX = InvalidType;
break;
}
}

else {

mRunningStatus_RX = InvalidType;
}

return true;
}
else
Expand Down