Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Kafka Implementation #2

Merged
merged 9 commits into from
May 23, 2022
Merged

Initial Kafka Implementation #2

merged 9 commits into from
May 23, 2022

Conversation

vlad-kyrychuk-nf
Copy link
Contributor

@vlad-kyrychuk-nf vlad-kyrychuk-nf commented May 19, 2022 •
edited by niemyjski
Loading

This is the first of a few passes. There is cleanup here but all tests are passing.

@CLAassistant
Copy link

CLAassistant commented May 19, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@niemyjski niemyjski changed the base branch from main to feature/implementation May 23, 2022 14:13
@niemyjski niemyjski changed the base branch from feature/implementation to main May 23, 2022 14:14
niemyjski
niemyjski approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@niemyjski niemyjski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some test clean up things we need to address but well make a pass before initial release.

@niemyjski niemyjski changed the title Feature/implementation Initial Kafka Implementation May 23, 2022
@niemyjski niemyjski merged commit 985c2a5 into FoundatioFx:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niemyjski niemyjski niemyjski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlad-kyrychuk-nf @CLAassistant @niemyjski