Skip to content

Commit

Permalink
🐛 Fix Robin Nano v3 filament runout pins (MarlinFirmware#23344)
Browse files Browse the repository at this point in the history
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
  • Loading branch information
attilabody and thinkyhead authored Dec 24, 2021
1 parent ca0215b commit 80a537c
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 15 deletions.
2 changes: 1 addition & 1 deletion Marlin/src/pins/mega/pins_OVERLORD.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
#define Z_MIN_PROBE_PIN 46 // JP4, Tfeed1
#endif

#if ENABLED(FILAMENT_RUNOUT_SENSOR)
#ifndef FIL_RUNOUT_PIN
#define FIL_RUNOUT_PIN 44 // JP3, Tfeed2
#endif

Expand Down
7 changes: 5 additions & 2 deletions Marlin/src/pins/pins_postprocess.h
Original file line number Diff line number Diff line change
Expand Up @@ -546,14 +546,17 @@
#undef K_MAX_PIN
#endif

// Filament Sensor first pin alias
#if HAS_FILAMENT_SENSOR
#define FIL_RUNOUT1_PIN FIL_RUNOUT_PIN
#define FIL_RUNOUT1_PIN FIL_RUNOUT_PIN // Filament Sensor first pin alias
#else
#undef FIL_RUNOUT_PIN
#undef FIL_RUNOUT1_PIN
#endif

#if NUM_RUNOUT_SENSORS < 2
#undef FIL_RUNOUT2_PIN
#endif

#ifndef LCD_PINS_D4
#define LCD_PINS_D4 -1
#endif
Expand Down
1 change: 0 additions & 1 deletion Marlin/src/pins/ramps/pins_FORMBOT_TREX3.h
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@
#define FAN_PIN 9
#define FAN1_PIN 12

#define NUM_RUNOUT_SENSORS 2
#define FIL_RUNOUT_PIN 22
#define FIL_RUNOUT2_PIN 21

Expand Down
6 changes: 2 additions & 4 deletions Marlin/src/pins/sam/pins_RURAMPS4D_11.h
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,8 @@
#define Z_MIN_PROBE_PIN 49
#endif

#if HAS_FILAMENT_SENSOR
#ifndef FIL_RUNOUT_PIN
#define FIL_RUNOUT_PIN Y_MIN_PIN
#endif
#ifndef FIL_RUNOUT_PIN
#define FIL_RUNOUT_PIN Y_MIN_PIN
#endif

//
Expand Down
6 changes: 2 additions & 4 deletions Marlin/src/pins/sam/pins_RURAMPS4D_13.h
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,8 @@
#define Z_MIN_PROBE_PIN 49
#endif

#if HAS_FILAMENT_SENSOR
#ifndef FIL_RUNOUT_PIN
#define FIL_RUNOUT_PIN Y_MIN_PIN
#endif
#ifndef FIL_RUNOUT_PIN
#define FIL_RUNOUT_PIN Y_MIN_PIN
#endif

//
Expand Down
2 changes: 1 addition & 1 deletion Marlin/src/pins/sanguino/pins_MELZI_CREALITY.h
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
#if SERVO0_PIN == BEEPER_PIN
#undef BEEPER_PIN
#endif
#elif ENABLED(FILAMENT_RUNOUT_SENSOR)
#elif HAS_FILAMENT_SENSOR
#ifndef FIL_RUNOUT_PIN
#define FIL_RUNOUT_PIN 27
#endif
Expand Down
4 changes: 2 additions & 2 deletions Marlin/src/pins/stm32f4/pins_MKS_ROBIN_NANO_V3_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,10 @@
#endif

#ifndef FIL_RUNOUT_PIN
#define FIL_RUNOUT_PIN MT_DET_1_PIN
#define FIL_RUNOUT_PIN PA4
#endif
#ifndef FIL_RUNOUT2_PIN
#define FIL_RUNOUT2_PIN MT_DET_2_PIN
#define FIL_RUNOUT2_PIN PE6
#endif

#ifndef POWER_LOSS_PIN
Expand Down

0 comments on commit 80a537c

Please sign in to comment.