[BES-1586] async_stream format / build phase of serializer #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milmazz
reviewed
Mar 13, 2024
mix.exs
Outdated
| @@ -36,10 +36,10 @@ defmodule Cereal.Mixfile do | |||
| # Type "mix help deps" for more examples and options | |||
| defp deps do | |||
| [ | |||
| {:ecto, ">= 2.0.0"}, | |||
| {:ecto, ">= 3.0.0"}, | |||
There was a problem hiding this comment.
This package should work without this dependency, I only see references to structs like Ecto.Changeset or Ecto.Association.NotLoaded.
mix.exs
Outdated
| {:ex_doc, "~> 0.19", only: :dev}, | ||
| {:scrivener, "~> 1.2 or ~> 2.0", optional: true}, | ||
| {:plug_cowboy, "~> 2.2"} | ||
| {:plug_cowboy, "~> 2.5"} |
| @@ -36,10 +36,10 @@ defmodule Cereal.Mixfile do | |||
| # Type "mix help deps" for more examples and options | |||
| defp deps do | |||
| [ | |||
| {:ecto, ">= 2.0.0"}, | |||
| {:ecto, ">= 3.0.0"}, | |||
| {:ex_doc, "~> 0.19", only: :dev}, | |||
| {:scrivener, "~> 1.2 or ~> 2.0", optional: true}, | |||
milmazz
approved these changes
Mar 13, 2024
mix.lock
Outdated
| "cowboy": {:hex, :cowboy, "2.7.0", "91ed100138a764355f43316b1d23d7ff6bdb0de4ea618cb5d8677c93a7a2f115", [:rebar3], [{:cowlib, "~> 2.8.0", [hex: :cowlib, repo: "hexpm", optional: false]}, {:ranch, "~> 1.7.1", [hex: :ranch, repo: "hexpm", optional: false]}], "hexpm", "04fd8c6a39edc6aaa9c26123009200fc61f92a3a94f3178c527b70b767c6e605"}, | ||
| "cowlib": {:hex, :cowlib, "2.8.0", "fd0ff1787db84ac415b8211573e9a30a3ebe71b5cbff7f720089972b2319c8a4", [:rebar3], [], "hexpm", "79f954a7021b302186a950a32869dbc185523d99d3e44ce430cd1f3289f41ed4"}, | ||
| "decimal": {:hex, :decimal, "1.4.0", "fac965ce71a46aab53d3a6ce45662806bdd708a4a95a65cde8a12eb0124a1333", [:mix], [], "hexpm", "76de71de4e2fa0b371b5359a060a3a3d38e74b2da7a1157a45e146a68f71e023"}, | ||
| "cowboy": {:hex, :cowboy, "2.10.0", "ff9ffeff91dae4ae270dd975642997afe2a1179d94b1887863e43f681a203e26", [:make, :rebar3], [{:cowlib, "2.12.1", [hex: :cowlib, repo: "hexpm", optional: false]}, {:ranch, "1.8.0", [hex: :ranch, repo: "hexpm", optional: false]}], "hexpm", "3afdccb7183cc6f143cb14d3cf51fa00e53db9ec80cdcd525482f5e99bc41d6b"}, |
There was a problem hiding this comment.
Seems that you forgot to do: mix deps.unlock --unused that should remove cowboy and plug_cowboy from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also updates deps.