fl16: Disable NKRO for now

The keyboard can still detect NKRO but the HID report limits that to 6KRO. Causes slow start up on Linux. Probably be related to: - qmk/qmk_firmware#8733 - qmk/qmk_firmware#14814 - qmk/qmk_firmware#19372 Signed-off-by: Daniel Schaefer <dhs@frame.work>
FrameworkComputer · Mar 23, 2023 · ef518f5 · ef518f5
1 parent 666109f
commit ef518f5
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 7 deletions.
diff --git a/keyboards/lotus/ansi/info.json b/keyboards/lotus/ansi/info.json
@@ -9,7 +9,7 @@
         "extrakey": true,
         "console": true,
         "command": false,
-        "nkro": true,
+        "nkro": false,
         "audio": false
     },
     "debounce": 5,

diff --git a/keyboards/lotus/factory.c b/keyboards/lotus/factory.c
@@ -52,7 +52,11 @@ void handle_factory_command(uint8_t *data) {
             print("Reading Device serial number\n");
 
 
+#ifdef SERIAL_NUMBER
             uprintf("Serial number: %s\n", ascii_serialnum);
+#else
+            uprintf("Serial number unavailable\n");
+#endif
             break;
         default:
             uprintf("Unknown factory command: %u\n", factory_command_id);

diff --git a/keyboards/lotus/gridpad/info.json b/keyboards/lotus/gridpad/info.json
@@ -9,7 +9,7 @@
         "extrakey": true,
         "console": true,
         "command": false,
-        "nkro": true,
+        "nkro": false,
         "audio": false
     },
     "debounce": 5,

diff --git a/keyboards/lotus/iso/info.json b/keyboards/lotus/iso/info.json
@@ -9,7 +9,7 @@
         "extrakey": true,
         "console": true,
         "command": false,
-        "nkro": true,
+        "nkro": false,
         "audio": false
     },
     "debounce": 5,

diff --git a/keyboards/lotus/jis/info.json b/keyboards/lotus/jis/info.json
@@ -9,7 +9,7 @@
         "extrakey": true,
         "console": true,
         "command": false,
-        "nkro": true,
+        "nkro": false,
         "audio": false
     },
     "debounce": 5,

diff --git a/keyboards/lotus/lotus.c b/keyboards/lotus/lotus.c
@@ -4,9 +4,11 @@
 #include "quantum.h"
 #include "lotus.h"
 
+#include "usb_descriptor.h"
+#include "usb_descriptor_common.h"
+
 // Prefix string literal with L for descriptors
-#define USBCONCAT(a, b) a##b
-#define USBSTR(s) USBCONCAT(L, s)
+#ifdef SERIAL_NUMBER
 USB_Descriptor_String_t PROGMEM SerialNumberString = {
     .Header = {
         .Size                   = sizeof(FALLBACK_SERIAL_NUMBER),
@@ -47,6 +49,7 @@ void *lotus_serial_number_string(void) {
 uint16_t lotus_serial_number_string_len(void) {
   return pgm_read_byte(&SerialNumberString.Header.Size);
 }
+#endif
 
 void keyboard_post_init_kb(void) {
   keyboard_post_init_user();

diff --git a/keyboards/lotus/numpad/info.json b/keyboards/lotus/numpad/info.json
@@ -9,7 +9,7 @@
         "extrakey": true,
         "console": true,
         "command": false,
-        "nkro": true,
+        "nkro": false,
         "audio": false
     },
     "debounce": 5,