Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create one Type object per type reference #1773

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Oct 2, 2024

Fixes #1768

@oxisto oxisto linked an issue Oct 2, 2024 that may be closed by this pull request
@oxisto oxisto marked this pull request as draft October 3, 2024 08:48
@oxisto oxisto force-pushed the 1768-create-one-type-object-for-each-type-usage branch 2 times, most recently from 4f5828a to 64ba3ef Compare October 8, 2024 21:22
@oxisto oxisto marked this pull request as ready for review October 8, 2024 22:40
@maximiliankaul maximiliankaul marked this pull request as draft October 9, 2024 14:56
@oxisto oxisto force-pushed the 1768-create-one-type-object-for-each-type-usage branch from 38bb9d0 to 782689a Compare November 6, 2024 09:45
@oxisto oxisto force-pushed the 1768-create-one-type-object-for-each-type-usage branch from 782689a to c2002ef Compare November 15, 2024 12:30
@oxisto oxisto marked this pull request as ready for review November 18, 2024 15:09
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 70.90909% with 16 lines in your changes missing coverage. Please review.

Project coverage is 75.08%. Comparing base (afad877) to head (e994814).

Files with missing lines Patch % Lines
...aisec/cpg/passes/inference/DFGFunctionSummaries.kt 69.04% 5 Missing and 8 partials ⚠️
...ec/cpg/passes/JavaExternalTypeHierarchyResolver.kt 50.00% 2 Missing ⚠️
...s/kotlin/de/fraunhofer/aisec/cpg/test/TestUtils.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...main/kotlin/de/fraunhofer/aisec/cpg/TypeManager.kt 83.33% <100.00%> (+0.47%) ⬆️
...otlin/de/fraunhofer/aisec/cpg/graph/NodeBuilder.kt 70.53% <ø> (ø)
...otlin/de/fraunhofer/aisec/cpg/graph/TypeBuilder.kt 57.50% <100.00%> (-7.21%) ⬇️
...n/de/fraunhofer/aisec/cpg_vis_neo4j/Application.kt 55.89% <ø> (-0.39%) ⬇️
...s/kotlin/de/fraunhofer/aisec/cpg/test/TestUtils.kt 72.34% <50.00%> (+0.76%) ⬆️
...ec/cpg/passes/JavaExternalTypeHierarchyResolver.kt 79.41% <50.00%> (+0.62%) ⬆️
...aisec/cpg/passes/inference/DFGFunctionSummaries.kt 74.35% <69.04%> (+5.64%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create one Type object for each type usage
1 participant