Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP! first step: import checking extensions #1854

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maximiliankaul
Copy link
Contributor

@maximiliankaul maximiliankaul commented Nov 19, 2024

Still a lot of problems and discussions we should have:

  • someCallExpressionNode.isImported: this should probably return whether the call is imported or not. However, if we think about foo.bar.baz or any other MemberExpression, then the current approach does not work.
  • Do we want the end-user to figure out the base of the MemberExpression and be user friendly when providing isImported, or do we make the end-user do all the work and simply provide isImported on Names?
  • Only thinking about MemberExpressions is not sufficient. References need to be considered, too.
  • As well as C++ using namespace stuff...
  • What do other languages do?

(Remember to test nested member expressions, too)

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.15%. Comparing base (bf8a497) to head (d678a8c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...kotlin/de/fraunhofer/aisec/cpg/graph/Extensions.kt 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...er/aisec/cpg/frontends/python/ExpressionHandler.kt 75.74% <100.00%> (+0.65%) ⬆️
...kotlin/de/fraunhofer/aisec/cpg/graph/Extensions.kt 62.36% <50.00%> (-0.18%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant