WIP! first step: import checking extensions #1854
Draft
+19
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a lot of problems and discussions we should have:
someCallExpressionNode.isImported
: this should probably return whether the call is imported or not. However, if we think aboutfoo.bar.baz
or any otherMemberExpression
, then the current approach does not work.base
of theMemberExpression
and be user friendly when providingisImported
, or do we make the end-user do all the work and simply provideisImported
onName
s?MemberExpressions
is not sufficient.Reference
s need to be considered, too.using namespace
stuff...(Remember to test nested member expressions, too)