chore: Update Node versions in GitHub CI #3238
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/AkRAV5f8x7hCa5SYxN99pNwj4Jwe |
| "svelte-preprocess": "^4.6.0" | ||
| }, | ||
| "devDependencies": { | ||
| "node-sass": "^5.0.0", |
There was a problem hiding this comment.
This devDep was single-handedly blocking Node 16 builds (issue). But it’s a devDep, so it’s fairly safe to remove.
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 12.x | ||
| node-version: 14.x |
There was a problem hiding this comment.
This was updated to just speed up the bundler test 🤷🏻
| @@ -12,7 +12,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest, windows-latest] | |||
| node-version: [12.x, 14.x, 15.x] | |||
| node-version: [12.x, 14.x, 16.x] | |||
There was a problem hiding this comment.
This was updated so we test the actual LTS version, 16, rather than 15.
| @@ -29,8 +29,3 @@ jobs: | |||
| run: yarn test | |||
| env: | |||
| CI: true | |||
| - name: dev test | |||
There was a problem hiding this comment.
This also removes the Snowpack dev server tests from every CI run. It was flaky, and slowed down the test suite. But this is now becoming outdated because as of the v3.1 rewrite, all builds are now piped through the dev server internally, so this test either is outdated, or will be soon.
Changes
~9 mindown to~7 min)~5 mindown to~3 min)Testing
Tests should pass
Docs
No docs; just a CI change