Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension committing edits while logged out #88

Closed
TechnoSquirrel69 opened this issue Jan 18, 2024 · 8 comments
Closed

Extension committing edits while logged out #88

TechnoSquirrel69 opened this issue Jan 18, 2024 · 8 comments
Assignees
Labels
bug Something isn't working needs more info Issue request more information from poster

Comments

@TechnoSquirrel69
Copy link

I have the "auto login" setting on "always", so I'm not sure why the extension committed edits without credentials here. I can share diffs and notification messages generated by the extension privately — my emails are enabled on the English Wikipedia.

@Frederisk
Copy link
Owner

I don't quite understand what you mean. What kind of certificate are you referring to?

There is nothing special about the automatic login function. The logic is:

  • when you click on the post page:
    • If you are logged in: post it.
    • Otherwise: log in firstly and then post.

Of course, if you still think there is a problem with any content, you are also welcome to send a message to my personal email address. <frederisk[AT]outlook.com>

@TechnoSquirrel69
Copy link
Author

It just happened again. The problem I'm facing is related to your second point: the extension is not logging in before publishing the edit, and is instead publishing it as an IP address. I'm not sure if the login is failing on the server side or the client side — maybe the automatic login function needs a condition to catch failed logins?

@Frederisk
Copy link
Owner

Oh, I see. What you're saying is that the extension occasionally posts edits by IP instead of logging in to the account, when using the auto-login feature.

Does this always happen? And does the extension show any warnings or errors?

@Frederisk Frederisk self-assigned this Jan 20, 2024
@Frederisk Frederisk added bug Something isn't working needs more info Issue request more information from poster labels Jan 20, 2024
@TechnoSquirrel69
Copy link
Author

No on both questions. I experimented a little bit to see what was causing the extension to commit edits without logging in, but couldn't pin down the issue exactly. However, I think both of the times the issue cropped up, I'd had VSCode open for a while without any activity. (Don't quote me on that, though.) After it happened the second time, I closed VSCode and tried again, and the extension logged in as expected before committing the edit.

@Frederisk Frederisk removed the needs more info Issue request more information from poster label Jan 22, 2024
@Frederisk
Copy link
Owner

I originally thought I found the problem, however, I checked the code again and didn't find much.

Can you tell me if a message with the content User "[UserName]"(UserID:"[UserID]" Login Result.... pops up when the error occurs?

@Frederisk Frederisk added the needs more info Issue request more information from poster label Jan 22, 2024
@Frederisk
Copy link
Owner

Or when you encounter the problem again, please take a screenshot of all the notifications that pop up in the lower right corner and pass them to me. (You can erase the content related to privacy)

I'm going to work on some temporary possible fixes for this issue to try and alleviate the problem.

Frederisk added a commit that referenced this issue Jan 22, 2024
@TechnoSquirrel69
Copy link
Author

I haven't had it crop up again (keeping in mind that I've been avoiding using the extension after leaving VSCode open for several hours, which I think is related to the issue), but I don't recall that the regular login notification popped up the previous couple times, just the normal "edit action success" message. I suppose that's kind of the problem, though, if that means that the extension is missing the login step before committing the edit.

@Frederisk
Copy link
Owner

I checked the logic again, but still found no problem. Instead I added more checking logic to avoid unnecessary IP leaks. I'm not sure this issue will ever be completely resolved. I will publish an improved version and close this issue, if this problem reappears in the future, please feel free to open this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs more info Issue request more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants