Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua integration #72

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Lua integration #72

wants to merge 5 commits into from

Conversation

davidxuang
Copy link

@davidxuang davidxuang commented Feb 2, 2023 •
edited
Loading

TODOs

  • Check the annotations.
  • Check if the integration works.
  • Determine what scope to use when calling vscode.workspace.getConfiguration.
  • Lua language server does not run in browser. Check if the dependency breaks anything in such environment.

@davidxuang davidxuang marked this pull request as ready for review March 11, 2024 15:58
@davidxuang
Copy link
Author

davidxuang commented Mar 11, 2024 •
edited
Loading

  • 浏览器下现在不会触发，但还需要测试引用的依赖会不会直接把宿主炸掉；
  • mw.wikibase 扩展函数比较多，我也不熟悉，有必要也加上注解吗？

@Frederisk
Copy link
Owner

mw.wikibase 扩展函数比较多，我也不熟悉，有必要也加上注解吗？

如果不確定倒是可以先不添加吧，或者等之後另開PR也行？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidxuang @Frederisk