Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unnecessary Apt Upgrade From Spellings #101

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Remove Unnecessary Apt Upgrade From Spellings #101

merged 1 commit into from
Feb 19, 2024

Conversation

HTRamsey
Copy link
Contributor

@HTRamsey HTRamsey commented Feb 17, 2024

Admittedly not very important, but you should only need the apt update portion to fix the Node.js problem that was occurring. The apt upgrade portion just wastes time upgrading firefox and other stuff. It added a minute to the spellings action from before/after the fix.

@Skptak
Copy link
Member

Skptak commented Feb 19, 2024

Thanks for raising this PR!
Per github instructions here it is only necessary to run sudo apt update, the sudo apt upgrade is unnecessary, as such this change seems reasonable

@rawalexe rawalexe requested a review from Skptak February 19, 2024 22:25
@rawalexe rawalexe merged commit b7ee231 into FreeRTOS:main Feb 19, 2024
49 of 50 checks passed
@HTRamsey HTRamsey deleted the dev-spellings branch February 19, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants