CI-CD URL Check Change #880

Skptak · 2023-11-08T19:22:15Z

Description

Misra's website now links to a human verification page - as such it cannot be checked by the URL Checker.
~~Exclude https://www.misra.org.uk/misra-c from the link verifier github action~~
The fix for this was implemented in the CI-CD Repo PR #91
Remove the urlCheck script and action, as this is performed by the CI-CD Link Verifier.

Remove formatting of the portable directory in this PR to enable PRs
#828, #829, #830, #831, #876, #881, #882, #883, #884, #885, #886, #887, and #888 to not have merge conflicts related to the change.

Test Steps

Checklist:

I have tested my changes. No regression in existing tests.
I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…w errors out every time due to captcha check

Skptak · 2023-11-08T19:27:33Z

.github/workflows/ci.yml

-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
+        uses: FreeRTOS/CI-CD-Github-Actions/link-verifier@main


This was incorrectly pointed to the v2 branch. Pointing back to mainline as part of this PR.

Skptak · 2023-11-08T19:28:03Z

.github/workflows/ci.yml

-      - name: URL Checker
-        run: |
-          bash kernel/.github/actions/url_verifier.sh kernel
+          exclude-urls: https://www.misra.org.uk/misra-c


This link now goes to a "Prove you're a human" page - which causes the link verifier to fail.

Skptak · 2023-11-08T19:28:34Z

.github/workflows/ci.yml

@@ -30,18 +30,9 @@ jobs:
      - name: Clone This Repo
        uses: actions/checkout@v3
      - name: Link Verification
-        uses: FreeRTOS/CI-CD-Github-Actions/link-verifier@v2
-
-  url-check:


Removing the kernel's custom script to instead use the CI-CD action that was already added and been used.

codecov · 2023-11-08T19:31:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c649ea) 93.51% compared to head (344407f) 93.51%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #880   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files           6        6           
  Lines        3175     3175           
  Branches      883      883           
=======================================
  Hits         2969     2969           
  Misses         99       99           
  Partials      107      107

Flag	Coverage Δ
unittests	`93.51% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…xclude portable directory from formatting check.

sonarcloud · 2023-11-08T23:48:08Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Skptak · 2023-11-09T22:53:15Z

.github/workflows/formatting.yml

      uses: FreeRTOS/CI-CD-Github-Actions/formatting-bot@main
-      id: check-formatting
+      with:
+        exclude-dirs: portable


We are not going to format the portable directory moving forward. Add this change to this PR to enable the PRs mentioned in the description to pass.

…#872) * Update mbedtls to version v3.2.1 * Adjust include paths for github workflow * Update FreeRTOS+TCP to v3.1.0 * Add initial VS project files for Kernel, +TCP, and mbedtls * winpcap: Consolidate to a single copy of WinPcap * Downgrade library projects to VS 2019. Add heap_4 to kernel. * Remove *.vcxproj.user files and add to gitignore * Disable unwanted kernel config options * Update FreeRTOS+TCP and Kernel include paths * Update FreeRTOS+TCP Windows Minimal sln * Remove .suo and .vcxproj.user files * Update mbedtls transport implementations for mbedtls v3.2.1 * Fix typo in mbedtls_freertos_port.c * Update vcxproj files for +TCP, Kernel, Mbedtls * Fix typo in name WindowSimulator -> WindowsSimulator * Add wpcap lib to FreeRTOS+TCP.vcxproj * Update FreeRTOS+TCP Minimal Demo for Windows Simulator * Mask MSVC string function warnings Aad _CRT_SECURE_NO_WARNINGS preprocessor definition. * Move projects to their own directories to make VisualStudio happy * mbedtls_freertos_port.c: Fix formatting? * Add coreHTTP, Logging libs. Adjust dependencies * Disable FreeRTOS Kernel malloc failed hook * Update coreHTTP Plaintext demo * Rename / relocate transport interface implementations * Remove old VS project files * Remove extra core_http_config.h files * Remove extra FreeRTOSConfig.h files * Remove extra FreeRTOSIPConfig.h files * Remove old mbedtls_config.h files * Remove old FreeRTOSConfig and core_http_config files * Update HTTP Mutual Auth Demo build files * Fix transport_plaintext.h include name * Update HTTP_Plaintext demo build files * Update CoreHTTP_S3_Download VS project files * Update HTTP_S3_Upload demo build files * Update CoreHTTP_S3_Download_Multithreaded demo build files * Add GithubActions builds for FreeRTOS+ CoreHTTP Demos * Update S3DownloadHTTPExample.c to be compatible with mbedtls 3.x * Update GithubActions FreeRTOS+ config file * Combine core_pkcs11_config.h files into a single one * Add corePKCS11 VS project file * Update corePKCS11 WinSim demo project and build files * Update corePKCS11 library to version 3.5.0 * Modifiying demos to build using static libraries * Adding a header file * Two more demos * Update corePKCS11 demo code and auto-format * Downgrade corePKCS11 library build file to v142 / VS 2019 * Speed up CI builds with selective submodule initialization * Separate corePKCS11 demo into it's own job. * Remove WIN32.vcxproj and WIN32.vcxproj.filters files * Remove old configuration header files Partially reverts 73829ced6061e4584e521185178a61b4a437c5e0 * Revert unwanted coreHTTP demo changes * Changing include paths for demos * Adding an include * MQTT WoflSSL Demo update * wolfSSL Demo changes * Config changes for MQTT Demos * Initial Device Defender demo update. * Initial Device Shadow demo update. * Update mbedtls_transport_pkcs11 for Mbedtls 3.x * Update corePKCS11 MQTT Mutual Auth demo * Add a default definition of SdkLog * Update CorePKCS11 + MQTT Mutual Auth demo sln name * Build all configs of coreHTTP demos * Update coreSNTP Demo build files. * Update coreSNTP Demo sln name * Update FreeRTOS+TCP Posix demo * Update FreeRTOS+TCP Qemu ARM MPS2 AN385 Demo * Update FreeRTOS+TCP Demo Github Actions builds * Update Fleet Provisioning WinSim Demo build files * Remove mbedtls_pk_info_t references from mbedtls_pk_pkcs11.h * Restore / update the FreeRTOS+TCP Minimal WinSim demo * Initial Jobs demo update. * Fix jobs demo build. * Initial OTA over HTTP demo update. * Initial OTA over MQTT demo update. * Ota_Over_Mqtt_Demo build fix. * OTA over MQTT demo fix. * Update HTTP demo solution file name for CI. * Update Github actions workflow to old HTTP demo names. * Update coreSTNP demo to old solution name. * Fix defender demo / fix mbedtls config to use threading alt. * Add MBEDTLS_CONFIG_FILE definition to each config * Fix config file name. * MQTT Mutual auth fixes. * Fix job demo. * Device shadow demo fixes. * Fix coreSNTP demo not setting alt threading functions for mbedtls. * Enable Static allocation, Add default hooks for FreeRTOS Kernel and +TCP * Add xPlatformIsNetworkUp platform function to FreeRTOS+TCP hooks * Enable runtime statistics in the Windows Simualator Kernel config * Revert "Fix coreSNTP demo not setting alt threading functions for mbedtls." This reverts commit 9069707519561ca8136d58c0f18fb176c9050a1d. * Revert mbedtls threading related config changes * Add xPlatformIsNetworkUp function prototype * Remove boileplate FreeRTOS kernel and +tcp hooks * Refactor device defender demo for clarity * Add wait loop calling xPlatformIsNetworkUp * Add missing vPlatformInitLogging function * Add vPlatformInitLogging and vLoggingPrintf defitions to logging headers * Updating the FreeRTOS_Plus_CLI_with_Trace_Windows_Simulator * Updating the FreeRTOS_Plus_Reliance_Edge_and_CLI_Windows_Simulator demo * Updates to the FreeRTOS_Plus_WolfSSL_Windows_Simulator demo * Fixing wrong include path * Upating FreeRTOS_Plus_WolfSSL_FIPS_Ready_Windows_Simulator demo * Update coreMQTT WinSim demos to print start and end condition. * Modifiying repos updated as part of the CLI demo GitHub workflow * Removing duplicate functions from the FreeRTOS_Plus_TCP_Minimal_Windows_Simulator demo * Updated FreeRTOS_Plus_TCP_UDP_Mode_CLI_Windows_Simulator demo * Updating corePKCS11_MQTT_Mutual_Auth_Windows_Simulator Demo to call the static function that creates task * Fix log message using unitialized string in MQTT Multitask demo. * Fixing a broken extern function * Fixing a typo extern function name * Added a reference to coreHTTP * Fixing a pre-processor issue in the OTA_Over_Http_Demo * Updating the MQTT_Mutual_Auth_Demo_with_BG96 demo * Updating the MQTT_Mutual_Auth_Demo_with_HL7802 demo * Changes to the MQTT_Mutual_Auth_Demo_with_SARA_R4 demo * Fix demos for CI. * Adding the source path to the CBMC proofs for FreeRTOS+TCP * Spell check fixes, adding words to lexicons * Fixing a typo * Add arg to skip prompt in setup script. * Update paths of script to be relative to the file. * Changing manifest.yml file to point to corePKCS11 3.5.0 * Added CI markers to cellular demos. * Fix cellular demo flow. * Fix celullar demos. * Initial TCP sockets wrapper rework - will break things. * First cellular demo fix for new sockets wrapper. * Minor fix to cellular sockets wrapper. * Fix mbedtls bio using FreeRTOS Plus TCP call. * Clean up BG96 demo project files. * Update HL7802 demo. * Fix SARA R4 demo for new sockets wrapper. * Fix Device Defender, Device Shadow, and Fleet PRovisioning. * Fix Jobs demo. * Fix OTA over HTTP demo. * Fix OTA over MQTT demo. * Fix HTTP mutual auth demo. * Fix OTA over MQTT demo endianness. * Fix OTA over HTTP demo endianness. * Fix HTTP Plaintext demo. * Fix HTTP S3 download demo. * Fix plaintext transport * Fix OTA demos. * Fix OTA demos. * Fix OTA HTTP demo. * Fix HTTP S3 Download multithreaded demo. * Fix HTTP S3 Upload demo * Fix corePKCS11 Mutual Auth demo. * Updating MQTT_Mutual_Auth * Update pkcs11 setup script. * Updating the MQTT_Basic_TLS Demo * Organize PKCS11 demos project. * Updating MQTT_Keep_Alive demo * Clean up SNTP demo. * Updated MQTT_Multitask demo * Updated MQTT_Plain_Text * Updating the MQTT_Serializer Demo * Updating corePKCS11_MQTT_Mutual_Auth_Windows_Simulator * Updating coreSNTP_Windows_Simulator * Clean up demo projects. * Add markers to PKCS11 mutual auth demo. * Fix Fleet Provisioning demo script. * Fix SNTP demo solution. * Fix coreSNTP project files. * Fix Fleet Provisiong script. * Fix fleet provisioning script. * Fix demo config template. * Fleet provisioning demo markers. * Updating MQTT_Mutual_Auth_wolfSSL demo and the transport_wolfSSL file * Fixing FreeRTOS_Plus_TCP_Echo_POSIX * Fixing CLI and Trace Demos * Fixing TCP_ECHO_POSIX demo * Adding a word to the lexicon * Remove unneeded files. * Update github workflows to use Ubuntu 20.04. * Change OTA demo target names to RTOSDemo for OTAE2E tests. * Fixing Headers * Updating headers * Two more headers * Adding words to the lexicon * Whitepsace * Ignore mbedtls config file for header check. * Removing FreeRTOS Header from the mbedtls_config_v3.2.1.h file * Fix bug in lPKCS11PkMbedtlsCloseSessionAndFree. Add doxygen api docs. * Update lexicon.txt * Fix spelling * Apply suggestions from code review Co-authored-by: jasonpcarroll <23126711+jasonpcarroll@users.noreply.github.com> * Add return code comment for p11_ecdsa_ctx_init * Rename WindowsSimulator folder to VisualStudio_StaticProjects. * Remove references to coroutines * Fix mbedtls_pk_pkcs11.c * Update to LTS 2.0 submodule pointers (FreeRTOS#880) * Update submodule pointers to LTS 2.0 * Initial coreMQTT 2.1.1 update. * Update AWS demos for coreMQTT 2.1.1 * Fix deprecated macro for coreMQTT demos. * Fix keep alive demo. * Fix plaintext demo. * Fix MQTT wolfSSL demo. * Fix MQTT PKCS11 demo. * Remove duplicate functions. * Fix Mutual auth demos for Cellular. * Fix OTA demos. * Fix header of plaintext demo config. * Set writev to NULL for OTA demos. * Fix mbedlts config for OTA demos. * Fix spelling. Co-authored-by: Jason Carroll <czjaso@amazon.com> * Removing blank line * Fix jobs demo race condition. * Fix race condition from WinPCap network interface. * Update lexicon. Co-authored-by: Paul Bartell <pbartell@amazon.com> Co-authored-by: Jason Carroll <czjaso@amazon.com> Co-authored-by: Paul Bartell <paul.bartell@gmail.com> Co-authored-by: jasonpcarroll <23126711+jasonpcarroll@users.noreply.github.com>

Skptak added 2 commits November 8, 2023 09:35

Remove the Kernel's custom URL check to just use the CI-CD Actions one

83b8234

Allow skipping the check for https://misra.org.uk/misra-c since it no…

6c4849a

…w errors out every time due to captcha check

Skptak requested a review from a team as a code owner November 8, 2023 19:22

paulbartell previously approved these changes Nov 8, 2023

View reviewed changes

Skptak commented Nov 8, 2023

View reviewed changes

This was referenced Nov 8, 2023

Revert Portable/Renesas formatting #876

Merged

Exclude the MISRA Website from CI-CD link verifier checks FreeRTOS/CI-CD-Github-Actions#91

Merged

Skptak dismissed paulbartell’s stale review via 0295271 November 8, 2023 23:23

Skptak changed the title ~~Fix URL Checker~~ CI-CD URL Check Change Nov 8, 2023

Skptak requested a review from paulbartell November 8, 2023 23:27

archigup previously approved these changes Nov 8, 2023

View reviewed changes

Skptak dismissed archigup’s stale review via 660334a November 8, 2023 23:47

Skptak force-pushed the fixURLCheck branch from 0295271 to 660334a Compare November 8, 2023 23:47

Don't need to exclude the misra URL, now handled in the CI-CD repo. E…

344407f

…xclude portable directory from formatting check.

Skptak force-pushed the fixURLCheck branch from 660334a to 344407f Compare November 8, 2023 23:47

Skptak requested a review from archigup November 9, 2023 00:11

ericbj29 approved these changes Nov 9, 2023

View reviewed changes

Skptak commented Nov 9, 2023

View reviewed changes

archigup approved these changes Nov 9, 2023

View reviewed changes

Skptak merged commit ad13a1f into FreeRTOS:main Nov 9, 2023
17 checks passed

Skptak deleted the fixURLCheck branch December 19, 2023 13:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI-CD URL Check Change #880

CI-CD URL Check Change #880

Skptak commented Nov 8, 2023 •

edited

Loading

Skptak Nov 8, 2023

Skptak Nov 8, 2023

Skptak Nov 8, 2023

codecov bot commented Nov 8, 2023 •

edited

Loading

sonarcloud bot commented Nov 8, 2023

Skptak Nov 9, 2023

CI-CD URL Check Change #880

CI-CD URL Check Change #880

Conversation

Skptak commented Nov 8, 2023 • edited Loading

Description

Test Steps

Checklist:

Related Issue

Skptak Nov 8, 2023

Choose a reason for hiding this comment

Skptak Nov 8, 2023

Choose a reason for hiding this comment

Skptak Nov 8, 2023

Choose a reason for hiding this comment

codecov bot commented Nov 8, 2023 • edited Loading

Codecov Report

sonarcloud bot commented Nov 8, 2023

Skptak Nov 9, 2023

Choose a reason for hiding this comment

Skptak commented Nov 8, 2023 •

edited

Loading

codecov bot commented Nov 8, 2023 •

edited

Loading