Remove the use of common buffer #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbartell
previously approved these changes
Aug 25, 2022
paulbartell
reviewed
Aug 26, 2022
|
|
||
| /*-----------------------------------------------------------*/ | ||
|
|
||
| static void addWillAndConnectInfo( const MQTTConnectInfo_t * pConnectInfo, |
There was a problem hiding this comment.
addWillAndConnectInfo is only called from sendConnectWithoutCopy. Can we incorporate addWillAndConnectInfo into that function instead?
There was a problem hiding this comment.
Doing that increases the complexity score.
paulbartell
reviewed
Aug 26, 2022
| if( pWillInfo != NULL ) | ||
| { | ||
| /* Serialize the topic. */ | ||
| iterator = addEncodedStringToVector( serializedTopicLength, |
There was a problem hiding this comment.
I'm not sure that this improves clarity really. Wouldn't it be simpler just to fill the array?
paulbartell
reviewed
Aug 26, 2022
| ( long int ) bytesSent ) ); | ||
| } | ||
| /* Send MQTT SUBSCRIBE packet. */ | ||
| status = sendSubscribeWithoutCopy( pContext, |
There was a problem hiding this comment.
Does sendSubscribeWithoutCopy need to be a separate function?
paulbartell
previously approved these changes
Aug 29, 2022
archigup
reviewed
Aug 29, 2022
archigup
reviewed
Aug 29, 2022
archigup
reviewed
Aug 29, 2022
archigup
reviewed
Aug 29, 2022
archigup
approved these changes
Aug 29, 2022
paulbartell
approved these changes
Aug 29, 2022
AniruddhaKanhere
added a commit
that referenced
this pull request
Sep 19, 2022
* Update ci.yml (#197) * Update ci.yml * Add main branch in the CI YAML * Add cancel callback API (#196) * Add cancel callback command * Update the function name * Fix formatting * Update memory estimates * Add State to MQTT_ProcessLoop so that it can be called in a non-blocking manner (#198) * Add stateful process-loop function * Add extra checks; fix bugs and add description of functions * Add index based stateful processloop * Clean up * Renamed functions to make them more coherent with their function * Remove unused function declarations * Fixed failing CI checks from previous commits except unit-test * Fixed spell check and updated size-table * Fix CBMC proofs * Empty-Commit to trigger CBMC proofs * Fix loop unwinding values in the Makefile * Add upper bound on the buffer size of MQTT * Increase minimum limit on buffer size to >0 * Add upper bound on the size of the buffer as well * CBMC: Add memmove stub to accelerate coverage The commit adds a stub for memmove accelerate CBMC coverage calculation. Without this stub, coverage for `MQTT_ProcessLoop` and `MQTT_ReceiveLoop` fails to converge (gets stuck generating the SAT formula for the memmove in `receiveSingleIteration`). This stub checks that src and dst are nonnull pointers and havocs dst. * Fix formatting Co-authored-by: Aniruddha Kanhere <ubuntu@ip-172-31-25-12.us-west-2.compute.internal> Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com> * Remove the use of common buffer (#199) * Make publish use internal buffers * Fix comment about packet ID * Try a different approach for ping and disconnect * Use writev and flush in conjuction with send * Update the publish method to use vectors * Add vectored IO to all functions * Fix formatting * Reduce complexity score * Fix spell check and complexity score * Fix breaking build * Add doxygen comments * Fix doxygen part 2 * Doxygen fix part 3 * Fix doxygen part 4 * Fix some checks * Fix memory tables * Fix some small errors * Fix compiler warnings and breaking CI checks from previous commit * Fix spell check and doxygen * Fix a couple of CBMC proofs * Fix ping and publish proofs * Update the function name * Fix more CBMC proofs * Fix MQTT Connect proof * Add unwinding loops * Fix last CBMC proof * Fix formatting * Update the Subscribe and Unsubscribe functions * Fix formatting and doxygen checks * Fix broken CBMC proofs * Fix memory statistic table * Revert changes from serializer source * update comments to clarify write requirements * Add a note for write function pointer * Fix spell check * Update changelog (#202) * Update MQTT logging so that log levels of the library do not leak (#205) * Replace publish state arrays with pointers Added an MQTT_InIt function for QoS > 0 publishes Fixed functions which were dealing with state arrays * Fix CI checks and clean up * Fix CBMC proofs * Fix sub and unsub CBMC proofs * Fix remaining proofs * Fix remaining CI checks * Fix spell check * Minor typo fix (#209) * Update core_mqtt.h (#208) * Update core_mqtt.h * Update core_mqtt.h Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com> * Update documentation and Doxygen comments in the source (#206) * Update comments of the MQTT_InIt function * Updating documentation of more of functions * Fix formatting and spell check * Update core_mqtt.h * Add hooks to the source code (#200) * Add mutex hooks * Clean up of code * Add doxygen comments and fix spell check * Fix LogError call * Fix formatting and memory table * Fix dereference failure * Update the hook names * Fix broken builds * Update the macros and variables * Reword the briefs of hooks and uncrustify * Fir formatting * Protect get packet ID * Fix formatting * Fix Unit tests (#212) * Fix Unit tests * Update unit tests after new changes * Fix more UT * add dummy calls to the transport * fix build error * Remove usused variables * Remove unsused variables * Remove usused variables * Unsued parameter * Fix ut failure * Fix uninitialized unit test variables * Fix ut expectation * Fix unit-tests * Fix unit test uninitialized variable * increase unit test coverage * increase unit test coverage * Fix unit test build * State coverage 100% * Serializer 100% coverage * 100% UT coverage * Fix formatting * Fix size table * Address PR comments Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com> * Remove unnecessary ternaries (#211) Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com> * Fix misra deviations (#213) * MISRA compliance update 1 * Fix MISRA errors * Zero MISRA violations; 13 suppressed * Fix CI checks * Update MISRA.md * Remove deviations * Fix MISRA.md file * Fix bug - wasn't incrementing vector length properly. * Remove unwanted files * Update comment to clarify the control flow of UT * Remove 'dev' branch from the CI checks * Update horrid threshold = 10 Co-authored-by: Aniruddha Kanhere <ubuntu@ip-172-31-25-12.us-west-2.compute.internal> Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com> Co-authored-by: jasonpcarroll <23126711+jasonpcarroll@users.noreply.github.com> Co-authored-by: alfred gedeon <28123637+alfred2g@users.noreply.github.com> Co-authored-by: Archit Gupta <71798289+archigup@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of common buffer used for creating and transmitting packets. The reception will be handled in the user provided buffer.