Updates after the shaka-player migration #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
absidue
commented
Jul 2, 2024
•
absidue
commented
- Remove video.js and plugins from the dependencies list and add shaka-player
- Remove notes about the lack of WebM support and 1080p limit.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
absidue
force-pushed
the
post-shaka-changes
branch
from
7eb8ff0 to
36d1035
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
efb4f5ff-1298-471a-8973-3d47447115dc
marked this pull request as ready for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 6, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE,
ChunkyProgrammer and
MarmadileManteater
PikachuEXE
approved these changes
Sep 6, 2024
kommunarr
approved these changes
Oct 19, 2024
github-actions
bot
added
PR: waiting for review
and removed
PR: waiting for review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.