Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Video starts playing from the beginning when the format is changed #2365

Closed
4 tasks done
absidue opened this issue Jun 29, 2022 · 28 comments · Fixed by #4978
Closed
4 tasks done

[Bug]: Video starts playing from the beginning when the format is changed #2365

absidue opened this issue Jun 29, 2022 · 28 comments · Fixed by #4978
Labels
B: content not loading B: inconsistent behavior B: race condition bug Something isn't working

Comments

@absidue
Copy link
Member

absidue commented Jun 29, 2022

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.

Describe the bug

  1. Set the default video format to "Audio Formats" in the Player Settings
  2. Navigate to a video
  3. Seek forward about half way
  4. Under the video player change the format to DASH

The video will load for a while but then instead of it playing from the position it was at when you changed formats it will start playing from the beginning.

Expected Behavior

When the format is changed under the video player, it should continue on from the position it was at before you changed the format.

Issue Labels

content not loading, inconsistent behavior, race condition

FreeTube Version

v0.16.0, 0.17.0 RC+

Operating System Version

Windows 10

Installation Method

Portable

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

n/a

Additional Information

No response

Nightly Build
@absidue absidue added the bug Something isn't working label Jun 29, 2022
@absidue absidue changed the title [Bug]: [Bug]: Video position isn't kept when the format is changed Jun 29, 2022
@absidue absidue changed the title [Bug]: Video position isn't kept when the format is changed [Bug]: Video starts playing from the beginning when the format is changed Jun 29, 2022
@efb4f5ff-1298-471a-8973-3d47447115dc

This comment was marked as outdated.

Sign in to view
MarmadileManteater added a commit to MarmadileManteater/FreeTubeAndroid that referenced this issue Aug 23, 2022
@MarmadileManteater
This resolves one part of this race condition.
287e940 
Timestamps from your history now populate into the videojs
player before it loads. There are still issues with changing formats.
This is related to #8 and FreeTubeApp#2365.
MarmadileManteater added a commit to MarmadileManteater/FreeTubeAndroid that referenced this issue Aug 23, 2022
@MarmadileManteater
Moved the check for history into the Vue props
0cb1677 
When the ft-video-player component loads,
it is passed the time stamp from history before it is
even initialized. Also, added a prop to pass back the
the currentTime from the video element and save that in history.

This should prevent the issue where the time stamp
doesn't populate until videojs loads. It should also
resolve some race conditions having to do with changing
formats by removing code with arbitrary wait times in favor
of observable properties.

This is related to #8 and FreeTubeApp#2365.
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@absidue absidue mentioned this issue Apr 18, 2024
Merged
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Closed
6 tasks
@stdedos
Copy link

stdedos commented May 27, 2024

Maybe hidden inside the "This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days." spam (maybe create a label prevent-stale?) - it seems that switching to audio works seamlessly if "enough time has passed".

e.g. on a 30min video, after 50s transition "just works".

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

That will be included yes. Im working on improving our labeling system, processes and flow

@stdedos
Copy link

stdedos commented May 27, 2024

Let me know if you need specific help 👍

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Closed
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B: content not loading B: inconsistent behavior B: race condition bug Something isn't working
Projects
Bug Reports
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate video player from video.js to shaka-player absidue/FreeTube
3 participants
@stdedos @absidue @efb4f5ff-1298-471a-8973-3d47447115dc