Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Change icon color of FT logo on About page based on set theme #4020

Closed
3 tasks done
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Sep 10, 2023 · 2 comments · Fixed by #5126
Closed
3 tasks done

[Feature Request]: Change icon color of FT logo on About page based on set theme #4020

efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Sep 10, 2023 · 2 comments · Fixed by #5126
Labels
E: visual improvement enhancement New feature or request good first issue Good for newcomers

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Depending on what theme u pick the FT icon in the top bar will change color. This isnt the case for the FT icon on the about page. Some themes are not compatible with the default FT icon. So it would make sense to use the same icon color everywhere based on the set theme.

Proposed Solution

Make icon consistent with the icon color of the set theme

Alternatives Considered

Dont implement this

Issue Labels

visual improvement

Additional Information

No response
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the enhancement New feature or request label Sep 10, 2023
@kommunarr kommunarr added the good first issue Good for newcomers label Sep 10, 2023
@Shubh8899
Copy link

I would like to work on this one.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

hi @Shubh8899 i assigned u!

@Shubh8899 Shubh8899 mentioned this issue Sep 14, 2023
Closed
1 task
AnshuMishra01 added a commit to AnshuMishra01/FreeTube that referenced this issue Dec 26, 2023
@AnshuMishra01
Change icon color of FT logo
bef70ce 
Change icon color of FT logo

Pull Request Type

 Feature Implementation
Related issue

closes FreeTubeApp#4020

Description
Changed icon color of FT logo on based on set theme

Available Methods :-

As far as I can see, you have three choices:

1) I used an online tool to vectorize our existing logo. You can add it to _icons (our current icon SVG is using a raster image, which doesn't work for this), add it inline to the template, and use the fill CSS property to dynamically change the color to the --primary-text-color for that theme.
logoBlack

2) You can create different versions of this logo icon by changing the fill="#ffffff" to the primary text color for the given theme and use those.

3) You can use an editor like GIMP to create logo images for the themes missing them (with the fill color of that theme's --primary-text-color) (probably more effort than two).

Implemented 2 option :)
@AnshuMishra01 AnshuMishra01 mentioned this issue Dec 26, 2023
Closed
@ducks ducks mentioned this issue May 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E: visual improvement enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@Shubh8899 @efb4f5ff-1298-471a-8973-3d47447115dc @kommunarr