Handle missing data in search results #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
|
@LuanRT RE your TODO here https://github.com/LuanRT/YouTube.js/blob/main/src/parser/classes/Channel.ts#L33, I presume that this is why they haven't renamed the properties. |
PikachuEXE
previously approved these changes
Jan 22, 2023
ChunkyProgrammer
previously approved these changes
Jan 23, 2023
github-actions
bot
removed
the
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
absidue
dismissed stale reviews from ChunkyProgrammer and PikachuEXE
via
b242226
absidue
force-pushed
the
handle-search-inconsistencies
branch
from
9454e09 to
b242226
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
absidue
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jan 24, 2023
|
Sorry for tapping on disable auto merge. I sometimes think this is another button😅 |
ChunkyProgrammer
approved these changes
Jan 24, 2023
PikachuEXE
approved these changes
Jan 24, 2023
github-actions
bot
removed
the
PR: waiting for review
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle missing data in search results
Pull Request Type
Description
YouTube's search results unfortunately don't always contain all of the information. This pull request adds logic to fix the errors that were occurring when FreeTube encountered the missing data.
Channel search results can contain any combination of handle, subscribers or video count.
Video search results don't always contain the published text.
Playlist search results don't always have a channel id, sometimes it's just some text like "Various artists".
Screenshots
Different types:
Testing
Set the search filter to channels and search for
zephyr whispersClear the search filters and search for
rihanna topicClear the search filters and search for
zephyr vol 1Desktop