Fix focus disappearing when visiting the settings #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
kommunarr
approved these changes
Sep 13, 2023
For me the focus is on about (which I expect) |
|
My brain must have stopped working for a moment while writing, because I meant to write about. |
PikachuEXE
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
I confirm that the result is the same as the one @absidue expected when her brain is working :)
ChunkyProgrammer
approved these changes
Sep 18, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 19, 2023
* development: Translated using Weblate (French) Avoid extending the VueI18n class as it won't exist in Vue 3 (FreeTubeApp#4046) Fix comment author focus outline being broken (FreeTubeApp#4041) Bump sass from 1.66.1 to 1.67.0 (FreeTubeApp#4052) Bump marked from 9.0.0 to 9.0.2 (FreeTubeApp#4054) Bump the babel group with 2 updates (FreeTubeApp#4050) Bump the eslint group with 1 update (FreeTubeApp#4051) Bump lefthook from 1.4.10 to 1.4.11 (FreeTubeApp#4055) Avoid extending the VueRouter class as it won't exist in Vue 3 (FreeTubeApp#4047) Fix focus disappearing when visiting the settings (FreeTubeApp#4042) Translated using Weblate (Catalan) Translated using Weblate (Bulgarian) Translated using Weblate (Croatian) Translated using Weblate (Hebrew) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (German) Translated using Weblate (Hungarian) Translated using Weblate (Spanish) Translated using Weblate (Estonian) Translated using Weblate (Ukrainian)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix focus disappearing when visiting the settings
Pull Request Type
Related issue
closes #4021
Description
Currently the settings page is first rendered with the password dialog, which focuses the password input and then immediately rerendered without it, if you don't have a password, which unset the focus. This is caused by the default value for
settingsUnlockedbeingtrueand us only setting it tofalsewhen themountedhook fires, changing to the created hook fixes the issue, as that fires before Vue does any rendering. The created hook fires after the component instance is created, the mounted hook fires after the component has been mounted into the DOM (html elements created, event listeners registered etc).Testing
Desktop