-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local API: Support the author-less auto-generated album playlists in video lists #4371
Local API: Support the author-less auto-generated album playlists in video lists #4371
Conversation
97086ce
to
34c1495
Compare
Make sure you don't have any search filters set, as it disappears if you set the filter to playlists #justYouTubeThings. |
Might have to scroll a bit, was below the fold for me, but you shouldn't need to press load more, you can also try quoting the query, I'll see if I can find any other queries that produce the same bug/need the same fix, as that's just the query that was provided in the issue. |
Probably going to be difficult to find other queries, as it just seems to be albums that YouTube wasn't able to map an artist channel to, because "Good Girl Gone Bad: The Remixes" for example works fine with the existing code, because it has a link to Rihanna's own YouTube channel. |
This PR should fix the issue when using the invidious API iv-org/invidious#3869 |
Searching |
Yes, that one works too, thank you. I'll add it to the testing section :) |
Dunno why the playlist image won't download for me, but image loading is fine when clicked inside Not working image URL (outside): https://i9.ytimg.com/s_p/OLAK5uy_nnZsC6XX9bXuAp8zvF-7N8Ucykb2dl2AE/maxresdefault.jpg?sqp=CICs-qoGir7X7AMGCP_a0aoG&rs=AOn4CLAl00IVUS7LwxPtK6KdG0OiwU0T_g&v=1700031871 |
Im noticing the same issue as @PikachuEXE is that something we want to address in here? |
I wonder if it's a VPN thing, not much we can do with YouTube giving us broken links, other than using a different one in the array or trying to fix them, but I don't think we can identify broken ones. |
Local API: Support the author-less auto-generated album playlists in video lists
Pull Request Type
Related issue
#4312 (comment) (yes this only fixes the bug in that comment, because the original issues is a different bug, that needs to be fixed on the YouTube.js side)
Description
This pull request adds support for auto-generated album playlists in video lists, including the search results. Those playlists don't have an author/channel, just a bit of text that says
Playlist
, so when FreeTube tries to get the author information, it errors.This only fixes the issue on the FreeTube side,
Screenshots
Here is a screenshot of the error, using the search query used in the comment on the issue
glauben sie ja nicht wen sie da vor sich haben
, as they only provided the hard to read log text instead of a screenshot:This is what the playlist looks like when the parsing is fixed:
Testing
Search for
glauben sie ja nicht wen sie da vor sich haben
and check that the playlist shows up (see screenshot above to see what it looks like).Alternate search query that produce the same issue, might need to click load more
The Strxwberry Vault
.