Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local API: Support the author-less auto-generated album playlists in video lists #4371

Merged

Conversation

absidue
Copy link
Member

@absidue absidue commented Nov 22, 2023

Local API: Support the author-less auto-generated album playlists in video lists

Pull Request Type

  • Bugfix

Related issue

#4312 (comment) (yes this only fixes the bug in that comment, because the original issues is a different bug, that needs to be fixed on the YouTube.js side)

Description

This pull request adds support for auto-generated album playlists in video lists, including the search results. Those playlists don't have an author/channel, just a bit of text that says Playlist, so when FreeTube tries to get the author information, it errors.

This only fixes the issue on the FreeTube side,

Screenshots

Here is a screenshot of the error, using the search query used in the comment on the issue glauben sie ja nicht wen sie da vor sich haben, as they only provided the hard to read log text instead of a screenshot:
screenshot of errors

This is what the playlist looks like when the parsing is fixed:
screenshot-of-the-parsed-album-playlist

Testing

Search for glauben sie ja nicht wen sie da vor sich haben and check that the playlist shows up (see screenshot above to see what it looks like).
Alternate search query that produce the same issue, might need to click load more The Strxwberry Vault.

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 22, 2023 18:22
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 22, 2023
@absidue absidue force-pushed the search-support-album-playlists branch from 97086ce to 34c1495 Compare November 22, 2023 19:00
@kommunarr
Copy link
Collaborator

Am not finding it in the search results for some reason

Screenshot_20231122_131141

@absidue
Copy link
Member Author

absidue commented Nov 22, 2023

Make sure you don't have any search filters set, as it disappears if you set the filter to playlists #justYouTubeThings.

@kommunarr
Copy link
Collaborator

Still nothin

Screenshot_20231122_131517

@absidue
Copy link
Member Author

absidue commented Nov 22, 2023

Might have to scroll a bit, was below the fold for me, but you shouldn't need to press load more, you can also try quoting the query, I'll see if I can find any other queries that produce the same bug/need the same fix, as that's just the query that was provided in the issue.

@absidue
Copy link
Member Author

absidue commented Nov 22, 2023

Probably going to be difficult to find other queries, as it just seems to be albums that YouTube wasn't able to map an artist channel to, because "Good Girl Gone Bad: The Remixes" for example works fine with the existing code, because it has a link to Rihanna's own YouTube channel.

@ChunkyProgrammer
Copy link
Member

This PR should fix the issue when using the invidious API iv-org/invidious#3869

@ChunkyProgrammer
Copy link
Member

Searching The Strxwberry Vault then fetching more might cause the issue too?

@absidue
Copy link
Member Author

absidue commented Nov 22, 2023

Yes, that one works too, thank you. I'll add it to the testing section :)

@PikachuEXE
Copy link
Collaborator

@efb4f5ff-1298-471a-8973-3d47447115dc

Im noticing the same issue as @PikachuEXE is that something we want to address in here?

@absidue
Copy link
Member Author

absidue commented Nov 25, 2023

I wonder if it's a VPN thing, not much we can do with YouTube giving us broken links, other than using a different one in the array or trying to fix them, but I don't think we can identify broken ones.

@FreeTubeBot FreeTubeBot merged commit 0bde0b3 into FreeTubeApp:development Nov 25, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 25, 2023
@absidue absidue deleted the search-support-album-playlists branch November 25, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants