-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a Nordic base theme #4542
Added a Nordic base theme #4542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
suggestion (non-blocking): Create an #EEE
color FreeTube icon and title used for this theme in an editor like GIMP, like is done with Dracula. The contrast (pictured below) is a bit jarring. However, given that we don't have this for the similar cases of the Dark or Black themes, I don't see this as an absolute necessity.
Ironically I didn’t make a new one because I saw that Black didn’t have one, I can make a new icon and commit it soon |
If thats the case i'll hold off approving |
Head branch was pushed to by a user without write access
6d9ea90
Just added the icon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably add it to the switch
https://github.com/FreeTubeApp/FreeTube/blob/development/src/main/index.js#L481
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Co-authored-by: Jason <84899178+jasonhenriquez@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added a Nordic base theme
Pull Request Type
Related issue
Closes #4540
Description
Added a Nordic theme option in theme settings and properly added it to the localization file. Customized the theme in themes.css following the suggested hex codes in the issues.
Screenshots
Before (System Default, light blue accents)
After (Nordic, light blue accents)
Testing
Desktop
Additional context