Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icon for channels button on side nav #5273

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Update icon for channels button on side nav #5273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
960b8ad
* Update icon for channels button on side nav
PikachuEXE Jun 17, 2024
50755a0
* Reduce size of new icon
PikachuEXE Jun 18, 2024
63b333a
* Align new icon manually
PikachuEXE Jun 19, 2024
6938d16
Merge branch 'development' into feature/channel-page-update-icon
PikachuEXE Jul 19, 2024
7a130ac
* Update mobile menu item icon
PikachuEXE Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/renderer/components/side-nav-more-options/side-nav-more-options.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@
margin-block-start: 0.5em;
}

.navIcon.fa-user-check {
/* Align icon according to torso */
transform: translateX(0.2em);
}

.moreOption {
display: block;
}
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/components/side-nav-more-options/side-nav-more-options.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
class="thumbnailContainer"
>
<font-awesome-icon
:icon="['fas', 'list']"
:icon="['fas', 'user-check']"
class="navIcon"
:class="applyNavIconExpand"
fixed-width
Expand Down
16 changes: 16 additions & 0 deletions src/renderer/components/side-nav/side-nav.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,19 @@
}

.navIcon {
block-size: 1em;
inline-size: 1.25em;
margin-inline-start: 10px;
}

.navIcon.fa-user-check {
/* This icon is too big by default */
inline-size: 1em;

/* Align icon according to torso */
transform: translateX(0.2em);
}

.navChannel .navLabel {
overflow: hidden;
margin-inline-start: 40px;
Expand All @@ -94,6 +104,7 @@
position: absolute;
inset-block-start: 50%;
transform: translateY(-50%);
text-align: center;
}

.channelThumbnail {
Expand Down Expand Up @@ -139,6 +150,11 @@
block-size: 1.3em;
}

.closed .navIconExpand.fa-user-check {
/* This icon is too big by default */
block-size: 1.15em;
}

.closed .navLabel {
margin-inline-start: 0;
inline-size: 100%;
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/components/side-nav/side-nav.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
class="thumbnailContainer"
>
<font-awesome-icon
:icon="['fas', 'list']"
:icon="['fas', 'user-check']"
class="navIcon"
:class="applyNavIconExpand"
fixed-width
Expand Down
2 changes: 2 additions & 0 deletions src/renderer/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ import {
faTimes,
faTimesCircle,
faTrash,
faUserCheck,
faUsers,
faUsersSlash,
} from '@fortawesome/free-solid-svg-icons'
Expand Down Expand Up @@ -187,6 +188,7 @@ library.add(
faTimes,
faTimesCircle,
faTrash,
faUserCheck,
faUsers,
faUsersSlash,

Expand Down