Switch to non-deprecated Electron navigation history APIs #5626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 1, 2024
ChunkyProgrammer
approved these changes
Sep 1, 2024
PikachuEXE
approved these changes
Sep 2, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 3, 2024
* development: (49 commits) Translated using Weblate (Serbian) Translated using Weblate (Turkish) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Italian) Translated using Weblate (Italian) Translated using Weblate (Italian) Translated using Weblate (Italian) Translated using Weblate (French) Translated using Weblate (German) Bump swiper from 11.1.10 to 11.1.12 (FreeTubeApp#5635) Translated using Weblate (Spanish) Bump the stylelint group with 2 updates (FreeTubeApp#5633) Migrate video player from video.js to shaka-player (FreeTubeApp#4978) Bump lefthook from 1.7.14 to 1.7.15 (FreeTubeApp#5634) Bump electron-context-menu from 4.0.2 to 4.0.4 (FreeTubeApp#5636) Bump youtubei.js from 10.3.0 to 10.4.0 (FreeTubeApp#5637) Cleanup the Hide Profile Pictures in Comments code (FreeTubeApp#5625) Switch to non-deprecated Electron navigation history APIs (FreeTubeApp#5626) ... # Conflicts: # src/renderer/store/modules/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to non-deprecated Electron navigation history APIs
Pull Request Type
Related issue
Description
Electron 32 deprecated the
webContents#goForward()andwebContents#goBack()methods in favour of the newwebContents#navigationHistory#goForward()andwebContents#navigationHistory#goForward()methods. As far as I can tell from looking at the relevant pull requests on their side nothing changed functionally, they just got moved so that the interface is more intuitive.Testing
As mentioned above nothing functionally has changed, but you can test this pull request by testing the
BackandForwardentries in theViewmenu of the app menu.Desktop