Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong live stream playlist used for subscriptions #5876

Conversation

ChunkyProgrammer
Copy link
Member

Fix wrong live stream playlist used for subscriptions

Pull Request Type

  • Bugfix

Description

UUPV is used for popular
UULV is used for latest streams

We had this swapped.

Desktop

  • OS: Linux Mint
  • OS Version: 22
  • FreeTube version: latest nightly

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 16, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 16, 2024 01:54
@kommunarr
Copy link
Collaborator

Good catch! For future reference, is there documentation somewhere on these?

@ChunkyProgrammer
Copy link
Member Author

Good catch! For future reference, is there documentation somewhere on these?

Iirc, @absidue and SamantazFox (invidious developer) both had scripts to brute force these values

Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nothing~

@FreeTubeBot FreeTubeBot merged commit df9fafd into FreeTubeApp:development Oct 16, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 16, 2024
@ChunkyProgrammer ChunkyProgrammer deleted the fix-wrong-live-stream-playlist-id-used-for-subscriptions branch October 16, 2024 05:13
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Oct 16, 2024
* development:
  Translated using Weblate (Polish)
  ! Fix no comment detection (FreeTubeApp#5879)
  Fix wrong live stream playlist used for subscriptions (FreeTubeApp#5876)
  Translated using Weblate (Arabic)
  Run linter when PRs are made against RC branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants