Apply active FreeTube theme to shaka-player menus #5986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
previously approved these changes
Oct 28, 2024
This comment was marked as outdated.
This comment was marked as outdated.
|
IIRC we are using the same colour variables for the volume and seekbar as we were with video.js, I'll try downgrading to a pre-shaka version and see how that was handled there. Also not caused by this pull requests, so if there is an easy solution it can be included in this pull request otherwise it should be considered for a future pull request instead. |
|
Looks like the same problem existed with video.js and was actually worse because at least with shaka-player the slider thumb is still visible (the white circle), so it was probably overlooked when this theme was introduced. @kommunarr it's your theme what should we do here?: 50% volume: 100% volume: |
|
I regret the hot pink theme and want to take it back for this very reason lol. I'd recommend either removing the hot pink theme altogether or adding a theme-specific override in |
absidue
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 2, 2024
ChunkyProgrammer
approved these changes
Nov 3, 2024
PikachuEXE
approved these changes
Nov 3, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 4, 2024
* development: (153 commits) Migrate FtTimestampCatcher to the composition API (FreeTubeApp#6064) Translated using Weblate (Polish) Added functionality to export a single playlist (FreeTubeApp#5779) Fix video player displaying a vertical scrollbar when context menu outside player container (FreeTubeApp#6075) Fix use of deprecated Invidious route on the videos subscription tab (FreeTubeApp#6057) Apply active FreeTube theme to shaka-player menus (FreeTubeApp#5986) Bump sass from 1.80.4 to 1.80.6 (FreeTubeApp#6071) Bump mini-css-extract-plugin from 2.9.1 to 2.9.2 (FreeTubeApp#6068) Translated using Weblate (Vietnamese) Bump webpack from 5.95.0 to 5.96.1 (FreeTubeApp#6069) Translated using Weblate (Vietnamese) Bump sass-loader from 16.0.2 to 16.0.3 (FreeTubeApp#6070) Bump lefthook from 1.8.1 to 1.8.2 (FreeTubeApp#6067) Bump the eslint group with 2 updates (FreeTubeApp#6066) Bump youtubei.js from 11.0.0 to 11.0.1 (FreeTubeApp#6072) Migrate PasswordSettings and PasswordDialog to the composition API (FreeTubeApp#6036) Add some missing jsdoc comments, add jsdoc eslint plugin (FreeTubeApp#6048) Fix shortcut for macOS setting shortcut in video page (FreeTubeApp#6054) Use decodingInfo's powerEfficient property when picking streams (FreeTubeApp#6061) Translated using Weblate (Afrikaans) ...
1 task
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
* Apply active FreeTube theme to shaka-player menus * Add primary color override for range containers with the Hot Pink theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply active FreeTube theme to shaka-player menus
Pull Request Type
Related issue
Description
This pull request overrides shaka-player's menu colours (white background, black text) to match the currently active base theme in FreeTube. The code isn't great but as we have to override shaka-player's CSS we have to use the same CSS selectors as they do.
Screenshots
Light
Dark
Black
Nordic
Hot Pink
Pastel Pink
Catppuccin Mocha
Dracula
Solarized Dark
Solarized Light
Testing
Test a few of FreeTube's base themes and see how the player menus look
Desktop