Switch comments to calculatePublishedDate and getRelativeTimeFromDate
#6086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
previously approved these changes
Nov 4, 2024
PikachuEXE
previously approved these changes
Nov 4, 2024
ChunkyProgrammer
added a commit
to ChunkyProgrammer/FreeTube
that referenced
this pull request
Nov 4, 2024
4 tasks
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Nov 6, 2024
|
oh didnt saw that pr had to be rebased :( |
|
@ChunkyProgrammer Now you understand why I opened |
|
Just in case what? Just because I didn't instantly solve the conflicts and can't work on FreeTube 24/7 doesn't mean I'm abandoning my pull requests. I also spent a bunch of time that I could have worked on FreeTube investigating the slow webpack build times and eslint linting times, in an attempt to improve our development experience, but I guess it doesn't count unless I am working directly on FreeTube... |
absidue
dismissed stale reviews from efb4f5ff-1298-471a-8973-3d47447115dc, PikachuEXE, and ChunkyProgrammer
via
4e91a71
absidue
force-pushed
the
comments-published-dates
branch
from
0409952 to
4e91a71
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
absidue
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 7, 2024
PikachuEXE
approved these changes
Nov 8, 2024
ChunkyProgrammer
approved these changes
Nov 8, 2024
github-actions
bot
removed
the
PR: waiting for review
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch comments to
calculatePublishedDateandgetRelativeTimeFromDatePull Request Type
Description
Published dates for videos and community posts were already using the
calculatePublishedDateandgetRelativeTimeFromDatefunctions, comments however were still using the oldtoLocalePublicationStringfunction. This pull request switches the comments over to the newer functions too, which means that thex unit agopublished date display should be the same again across the app. As the old function is now unused we can remove it as well as the translation strings that it was using (it also removes the other unused strings under theVideo.Published.*key), because the newer functions use the built-inIntl.RelativeTimeFormatclass.@ChunkyProgrammer You'll need to make the same adjustment in your Piped pull request as that currently uses the function that this pull reqeust removes.
This pull request also fixes the storyboard issue that was introduced in the jsdoc pull request so that this pull request can actually be tested.
Testing
Check that the published dates show up on comments with both API backends
Desktop