Migrate Popular view to composition API #6129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
absidue
previously approved these changes
Nov 10, 2024
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
absidue
reviewed
Nov 11, 2024
| onMounted(() => { | ||
| document.addEventListener('keydown', keyboardShortcutHandler) | ||
|
|
||
| shownResults.value = popularCache.value || [] |
There was a problem hiding this comment.
Suggested change
| shownResults.value = popularCache.value || [] |
| const { t } = useI18n() | ||
|
|
||
| const isLoading = ref(false) | ||
| const shownResults = shallowRef([]) |
There was a problem hiding this comment.
Suggested change
| const shownResults = shallowRef([]) |
| document.addEventListener('keydown', keyboardShortcutHandler) | ||
|
|
||
| shownResults.value = popularCache.value || [] | ||
| if (!shownResults.value || shownResults.value.length < 1) { |
There was a problem hiding this comment.
Suggested change
| if (!shownResults.value || shownResults.value.length < 1) { | |
| if (shownResults.value.length === 0) { |
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
absidue
reviewed
Nov 12, 2024
absidue
approved these changes
Nov 13, 2024
PikachuEXE
approved these changes
Nov 14, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 15, 2024
github-actions
bot
removed
the
PR: waiting for review
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
* Migrate Popular to composition API * remove comment, use shallowRef for shownResults Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com> * Optimize setting shownResults Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com> * Fix typo Co-authored-by: absidue <48293849+absidue@users.noreply.github.com> --------- Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Popular to composition API
Pull Request Type
Description
This pull request migrates the Popular view to the composition API.
Testing
Desktop