Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor hiding when first opening video #6135

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

OothecaPickle
Copy link
Contributor

@OothecaPickle OothecaPickle commented Nov 10, 2024

Fix cursor hiding when opening video

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

further resolves #5838
fixes cursor hiding in the first case of @geominorai's comment

Description

Adds the no-cursor class to the video container during initialization. This fixes scenarios wherein the cursor would not be hidden if it was within the video container area before the player finished loading.

Screenshots

Testing

Click on a video on the subscriptions page such that the cursor will be in the video player area when the video loads (without moving the cursor after clicking), observe that the cursor is properly hidden.

Desktop

  • OS: macOS
  • OS Version: 10.15.7
  • FreeTube version: 5b474cd

Additional context

I don't know how to go about fixing cursor hiding when the cursor is over the seek bar, it might be best to comment about that issue upstream.

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 10, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 10, 2024 20:56
@absidue
Copy link
Member

absidue commented Nov 10, 2024

@OothecaPickle Also please try avoiding linking the FreeTube and shaka-player repos together in the future, as shaka-player is a Google project and YouTube is a Google service and we don't need to call more attention to FreeTube than there already is.

@OothecaPickle
Copy link
Contributor Author

@OothecaPickle Also please try avoiding linking the FreeTube and shaka-player repos together in the future, as shaka-player is a Google project and YouTube is a Google service and we don't need to call more attention to FreeTube than there already is.

I understand, I'll refrain from doing so in the future.

auto-merge was automatically disabled November 10, 2024 21:27

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 10, 2024 21:27
@absidue
Copy link
Member

absidue commented Nov 10, 2024

I haven't tested this pull request yet, but as it always adds that class it will likely hide the cursor even when auto-play is disabled, which means it will be paused and the controls visible (which is when the cursor should be visible too).

@OothecaPickle
Copy link
Contributor Author

OothecaPickle commented Nov 10, 2024

I haven't tested this pull request yet, but as it always adds that class it will likely hide the cursor even when auto-play is disabled, which means it will be paused and the controls visible (which is when the cursor should be visible too).

When a video is paused, shaka already does hide the cursor after a few seconds, while leaving the controls visible.

@FreeTubeBot FreeTubeBot merged commit f9736fb into FreeTubeApp:development Nov 17, 2024
6 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 17, 2024
Soham456 pushed a commit to Soham456/FreeTube that referenced this pull request Dec 5, 2024
* hide cursor when opening video

* add explanatory comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cursor no longer automatically hides alongside player controls
5 participants