Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Hashtag view to composition api #6137

Conversation

ChunkyProgrammer
Copy link
Member

Migrate hashtag view to composition api

Pull Request Type

  • Refactoring - Composition API migration

Description

This pull request migrates the Hashtag view to the composition API.

Testing

  • on local/invidious api
  • search #hi
  • click on hashtag result
  • fetch more results

Desktop

  • OS: Linux Mint
  • OS Version: 22
  • FreeTube version: 0.22.0

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 10, 2024 21:39
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 10, 2024
src/renderer/views/Hashtag/Hashtag.vue Outdated Show resolved Hide resolved
src/renderer/views/Hashtag/Hashtag.vue Outdated Show resolved Hide resolved
src/renderer/views/Hashtag/Hashtag.vue Outdated Show resolved Hide resolved
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
@FreeTubeBot FreeTubeBot merged commit d158d29 into FreeTubeApp:development Nov 15, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 15, 2024
Soham456 pushed a commit to Soham456/FreeTube that referenced this pull request Dec 5, 2024
* Migrate hashtag view to composition api

* Update vue template

* Fix vue3 compatibility, exclude code when local api isn't supported

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>

---------

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants