Use dirent.parentPath instead of deprecated .path #6172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Nov 17, 2024
ChunkyProgrammer
approved these changes
Nov 17, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 17, 2024
github-actions
bot
removed
the
PR: waiting for review
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use dirent.parentPath instead of deprecated .path
Pull Request Type
Description
Dirent.pathwas removed in this Node.js commit nodejs/node@d9540b5 it hasn't been released yet but when it does it will break this script, so I'm updating the script now already so we don't have to wonder later why the production (nightly, release etc) builds are failing.Testing
yarn run pack(don't leave out therunpart, otherwise you'll just get a tar.gz npm bundle)npx prettier@2.8.8 --write --no-config dist/main.js, prettier is more forceful than other formatters which is why I used it to make the mimified file readable (prettier 3 silently fails on the command line, which is why I explicitly specified the last version of v2)/static/indist/main.jsDesktop