local API: Fix playlists and podcasts not appearing in search results #6196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
absidue
changed the title
github-actions
bot
added
the
PR: waiting for review
absidue
force-pushed
the
lockup-view-playlists
branch
from
54eecb3 to
cca827a
Compare
ChunkyProgrammer
approved these changes
Nov 19, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 19, 2024
ChunkyProgrammer
added a commit
to ChunkyProgrammer/FreeTube
that referenced
this pull request
Nov 19, 2024
…in this function
PikachuEXE
approved these changes
Nov 20, 2024
github-actions
bot
removed
the
PR: waiting for review
ChunkyProgrammer
added a commit
to ChunkyProgrammer/FreeTube
that referenced
this pull request
Nov 20, 2024
…in this function
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 24, 2024
* development: (273 commits) Translated using Weblate (Serbian) Translated using Weblate (Czech) Translated using Weblate (French) Translated using Weblate (German) Translated using Weblate (Spanish) Fix text colour in player overflow menu (FreeTubeApp#6213) Add warning message to proxy settings (FreeTubeApp#6099) Migrate SubscribedChannels view to Composition API (FreeTubeApp#6131) Translated using Weblate (Croatian) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Afrikaans) Translated using Weblate (Afrikaans) Better player error handling (FreeTubeApp#6180) Translated using Weblate (Arabic) Translated using Weblate (Afrikaans) local API: Fix playlists and podcasts not appearing in search results (FreeTubeApp#6196) Translated using Weblate (Serbian) Translated using Weblate (Hungarian) Bump shaka-player from 4.11.11 to 4.12.1 (FreeTubeApp#6193) Translated using Weblate (French) ... # Conflicts: # src/renderer/views/SubscribedChannels/SubscribedChannels.js
1 task
FreeTubeBot
pushed a commit
that referenced
this pull request
Dec 2, 2024
* Add support for home tab on channels * Remove some unneeded code * Add setting to hide channel home tab * Switch to Composition API * Add Play All link when possible, parse more types * fix typo for home tab aria-controls Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com> * move distraction free hide home setting * Filter home data for setting featured channels * fix publish date parsing * Add support for shelf subtitle * run lint-fix * add jsdoc for added function * implement code suggestions, fix lockupview * add support for parsing subtitle and playlistId for richshelf * exclude home tab for IV * implement code suggestions, change `Play all` to `View playlist` Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com> * remove lockupview case since #6196 will handle parsing it in this function * use list icon instead of bookmark icon Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com> * open all details by default * add case 'ALBUM' for lockupView parsing * change default page to home page when local api is enabled and home page isnt hidden when entering a channel url --------- Co-authored-by: absidue <48293849+absidue@users.noreply.github.com> Co-authored-by: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com>
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
* Add support for home tab on channels * Remove some unneeded code * Add setting to hide channel home tab * Switch to Composition API * Add Play All link when possible, parse more types * fix typo for home tab aria-controls Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com> * move distraction free hide home setting * Filter home data for setting featured channels * fix publish date parsing * Add support for shelf subtitle * run lint-fix * add jsdoc for added function * implement code suggestions, fix lockupview * add support for parsing subtitle and playlistId for richshelf * exclude home tab for IV * implement code suggestions, change `Play all` to `View playlist` Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com> * remove lockupview case since FreeTubeApp#6196 will handle parsing it in this function * use list icon instead of bookmark icon Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com> * open all details by default * add case 'ALBUM' for lockupView parsing * change default page to home page when local api is enabled and home page isnt hidden when entering a channel url --------- Co-authored-by: absidue <48293849+absidue@users.noreply.github.com> Co-authored-by: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com>
jlvivero
pushed a commit
to jlvivero/FreeTube
that referenced
this pull request
Dec 7, 2024
* Add support for home tab on channels * Remove some unneeded code * Add setting to hide channel home tab * Switch to Composition API * Add Play All link when possible, parse more types * fix typo for home tab aria-controls Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com> * move distraction free hide home setting * Filter home data for setting featured channels * fix publish date parsing * Add support for shelf subtitle * run lint-fix * add jsdoc for added function * implement code suggestions, fix lockupview * add support for parsing subtitle and playlistId for richshelf * exclude home tab for IV * implement code suggestions, change `Play all` to `View playlist` Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com> * remove lockupview case since FreeTubeApp#6196 will handle parsing it in this function * use list icon instead of bookmark icon Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com> * open all details by default * add case 'ALBUM' for lockupView parsing * change default page to home page when local api is enabled and home page isnt hidden when entering a channel url --------- Co-authored-by: absidue <48293849+absidue@users.noreply.github.com> Co-authored-by: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local API: Fix playlists and podcasts not appearing in search results
Pull Request Type
Related issue
closes #6183
Description
This pull request adds support for
LockupViews with thecontent_typesPLAYLISTandPODCASTin search results. In preparation for YouTube usingLockupViews in more places, I moved the parsing of them to their own function. Originally I was going to doVIDEOin the watch next feed too but I haven't received them myself yet and the sample I was given only contained normal videos, so I don't know what the data looks like for live streams or upcoming premieres.Testing
Search for a pocast e.g. "WAN Show" and check that it appears in the search results.
Search for a playlist e.g. "Pop Music Playlist - Timeless Pop Songs (Updated Weekly 2024)" and check that it appears in the search results.
Desktop