Better description for hiding watched vids

[lamteteeow]

Title

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

closes #6389

Description

Hide Videos on Watch confused me and very likely others too so I made some minor changes to the text.

The reason why it should be Videos marked as WATCHED and not simply watched Videos is because of future features. If there is an option for user to mark a video manually as WATCHED (probably watched somewhere else) then this button should also apply.

Screenshots

Testing

Desktop

• OS: Windows
• OS Version: 23H2
• FreeTube version: v0.22.1 Beta

Additional context

[ChunkyProgrammer]

I'd recommend keeping the label the same and only updating the value here (otherwise you'll have to update the label for all languages):

FreeTube/static/locales/en-US.yaml

Line 489 in 96bcdc3

Hide Videos on Watch: Hide Videos on Watch

[kommunarr]

I also do not think we need anything in all-caps or otherwise. I would contend that the existing label is good at communicating the constancy of the setting, and also that the use case of manually marking videos as watched (as is currently possible) is implied enough such as to not necessitate special wording.

[efb4f5ff-1298-471a-8973-3d47447115dc]

I agree with @kommunarr here i dont see a reason to change this.

confused me and very likely others too

If you're confused about it, that's fine. However, trying to strengthen your argument by making invalid claims about what others are thinking doesn't hold up

[lamteteeow]

If you're confused about it, that's fine. However, trying to strengthen your argument by making invalid claims about what others are thinking doesn't hold up.

@efb4f5ff-1298-471a-8973-3d47447115dc

• I base my argument on this [Feature Request]: Hide/sort channel videos based on viewed or not #5500 [Feature Request]: option to hide watched videos in channel view #4497 [Feature Request]: Hide "Watched" videos from recommended, channels and playlists #5189
• I got this issue while sitting together with a German friend, hence the statement. Changed language to German, same result for both.
• Calling me out for something I carefully wrote very likely seems pedantic to me.

So far searching through the Issue section, the term Hide Videos on Watch is mostly used by developers/maintainers/members. Others have created their issues using different ways (to me more intuitive) to call it, which exist in #1362 #5261 #4863 #5189 #4497 #5500, etc. Most of them are Hide watched videos or related.

I agree with @kommunarr, Hide watched videos seems more concise and accurately reflects the term users are using.

I love the app, played around with it and only then figured out what that button does. If this seems more like a "me" problem then feel free to close the PR. Otherwise let me know if I should continue as @ChunkyProgrammer recommended.

[efb4f5ff-1298-471a-8973-3d47447115dc]

I got this issue while sitting together with a German friend, hence the statement. Changed language to German, same result for both.

Calling me out for something I carefully wrote very likely seems pedantic to me.

Over the past years i have seen allot of people making claims about others when they want something implemented. So i made an assumption here and that was wrong of me but i do stand firm on the argument that you should have made it clear why you said that in the first place. You cannot just say something without proper argumentation

So far searching through the Issue section, the term Hide Videos on Watch is mostly used by developers/maintainers/members. Others have created their issues using different ways (to me more intuitive) to call it, which exist in #1362 #5261 #4863 #5189 #4497 #5500, etc. Most of them are Hide watched videos or related.

This boils down to a subjective change and still dont see a reason to change this

[lamteteeow]

I was thinking it should be better for everyone. In that case, I will close the PR. Thanks for answering.