Add missing release builds #6415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE,
absidue,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
|
Can we put linux entries together (instead of some below MacOS entries (Compared with https://github.com/FreeTubeApp/FreeTube/blob/development/.github/workflows/build.yml |
I would like to do the grouping of the builds in a separate PR for both the release and build workflow as there is some randomness going on in general
I added no |
|
|
PikachuEXE
approved these changes
Dec 19, 2024
kommunarr
approved these changes
Dec 20, 2024
absidue
approved these changes
Dec 20, 2024
github-actions
bot
removed
the
PR: waiting for review
4 tasks
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Dec 21, 2024
* development: (57 commits) Translated using Weblate (Ukrainian) Translated using Weblate (Serbian) Translated using Weblate (Hungarian) Translated using Weblate (Icelandic) Translated using Weblate (Estonian) Translated using Weblate (Czech) Translated using Weblate (French) add missing release builds (FreeTubeApp#6415) Translated using Weblate (Serbian) Translated using Weblate (German) Translated using Weblate (Italian) Translated using Weblate (Chinese (Traditional Han script)) apply overflow menu text color change only to overflow menu (not to stats button) (FreeTubeApp#6406) Make a single IPC call for the navigation history (FreeTubeApp#6366) Added buttons to hide hidden channels/text (FreeTubeApp#6156) Translated using Weblate (Serbian) Translated using Weblate (Afrikaans) Translated using Weblate (Afrikaans) Translated using Weblate (Vietnamese) Translated using Weblate (Afrikaans) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing release builds
Pull Request Type
Related issue
#6157
Description
This PR adds the following release builds:
Testing
As this is a release workflow im not sure how to properly test it. This should just work out of the box. Almost everything could be taken over from the nightly build workflow. The only thing im worried about is the
asset_content_typefor the Pacman build, that was the only real thing i had to figure out as there were varying answers online.Additional context
This journey is only part one of many PR's (well i hope not too many) to come on this subject and has been triggered by @PikachuEXE PR. I noticed that we had more nightly builds than release builds so i went on a quest to provide these missing builds to users so they wouldnt need to use the nightly builds.