Bugfix/page transition loader #68
Conversation
✅ Deploy Preview for golden-caramel-d2c3a7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please back out the prefetch change.
See nuxt/nuxt#18600 for discussion and background.
…On 26 January 2024 01:39:00 GMT, Pavel Mironov ***@***.***> wrote:
Closes #52
Also in scope of this pr:
- no-prefetch removed from navbar to preload other pages (defined in the navbar) in idle mode
- blur effect when loader appearing
You can view, comment on, or merge this pull request online at:
#68
-- Commit Summary --
* add: transition loader
* chore: remove no-prefetch from navbars
* feat: loader after 5s on slow internet
-- File Changes --
M .eslintrc.js (1)
M app.vue (22)
M components/NavbarDesktop.vue (15)
M components/NavbarMobile.vue (8)
-- Patch Links --
https://github.com/Freegle/iznik-nuxt3/pull/68.patch
https://github.com/Freegle/iznik-nuxt3/pull/68.diff
--
Reply to this email directly or view it on GitHub:
#68
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
|
Using the preview deployment I loaded the site and then tried using Chrome Developer Tools to set the network offline, and then transition to another page. I see a blurring, but no loading indicator:
What do you see? |
This reverts commit f6ce9ae.
Yup, its valid. Somehow I forgot to commit loading component last night :) It should be fixed already.
Currently nuxt implemented smart preloading which will preload resources only for links in the viewport and if internet connection is good. I reverted it back for now but I'm pretty sure we don't need to disable it (at least for navbar modules). |
|
Thanks. Are you able to fade in the blur and loading indicator? |
Sure. I added 0.25ms transition for blur & loader. |
|
Thanks. That looks good, but on mobile the navbars are still visible - can you look at blurring those out too? The same may apply to the sticky ad bar at the bottom. |
Are you sure that blurring navbars/footer is a good idea? User possible can change his mind on loading time and in that case on unblurred navbar he'll be able to click on another module from navbars/footer. |
|
I think you're right.
In that case this one is done, thanks. I'll merge it in.
…On 27 January 2024 19:48:28 GMT, Pavel Mironov ***@***.***> wrote:
> Thanks. That looks good, but on mobile the navbars are still visible - can you look at blurring those out too? The same may apply to the sticky ad bar at the bottom.
Are you sure that blurring navbars/footer is a good idea? User possible can change his mind on loading time and in that case on unblurred navbar he'll be able to click on another module from navbars/footer.
--
Reply to this email directly or view it on GitHub:
#68 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
Closes #52
Also in scope of this pr: