Fallback to configured environment when no server/env environment is found #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
approved these changes
May 5, 2020
|
What is the hold up here? This was approved months ago. We need this fix as well. |
|
Thank you, Geoffrey! 🎉 |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test environment in our setup at work is not called
testbutlocal_test, and we had a problem where the right dotenv file was not loaded from our bootstrap (.envwas loaded instead of.env.local_test).After a quick investigation, it appears that
SymfonyExtensiondoes not use the configured environment but rather fallbacks to hardcodedtest. This PR fixes that.I have also renamed the
fallbackToTestEnvironmentmethod to better reflect its purpose.