Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 8.1 compatibility #175

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Add PHP 8.1 compatibility #175

merged 1 commit into from
Dec 10, 2021

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Nov 13, 2021

Solves these errors on PHP 8.1:

Return type of FriendsOfBehat\SymfonyExtension\Mink\MinkParameters::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

@ruudk
Add PHP 8.1 compatibility
8a48661 
Return type of FriendsOfBehat\SymfonyExtension\Mink\MinkParameters::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
@ruudk
Copy link
Contributor Author

ruudk commented Nov 19, 2021

@pamil Can this be merged so that people can continue preparing their applications for PHP 8.1 that is expected to be released next week? 🙏 Best to merge together with #174.

@ruudk
Copy link
Contributor Author

ruudk commented Nov 29, 2021

@dunglas Are you able to approve the workflow so that we can see if the tests pass?

@dunglas
Copy link
Contributor

dunglas commented Nov 30, 2021

@ruudk unfortunately no. I'm not a maintainer of this package.

@pamil pamil merged commit b67f25e into FriendsOfBehat:master Dec 10, 2021
@pamil
Copy link
Member

pamil commented Dec 10, 2021

Thanks, Ruud! 🎉

@ruudk ruudk deleted the php-81-compat branch December 10, 2021 14:24
@ruudk
Copy link
Contributor Author

ruudk commented Dec 10, 2021

Thanks, could you tag it?

ruudk added a commit to ruudk/SymfonyExtension that referenced this pull request Dec 14, 2021
@ruudk
Add return type mixed to offsetGet
237df2e 
Turns out that FriendsOfBehat#175 was not enough to make Symfony happy:
```
Method "ArrayAccess::offsetGet()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "FriendsOfBehat\SymfonyExtension\Mink\MinkParameters" now to avoid errors or add an explicit @return annotation to suppress this message.
```
@ruudk ruudk mentioned this pull request Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruudk @dunglas @pamil