Fix the build pipeline in GitHub Actions #191
Conversation
|
|
||
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| coverage: none | ||
| ini-values: "memory_limit=-1" | ||
| ini-values: "memory_limit=-1, zend.assertions=1" |
There was a problem hiding this comment.
Just to be sure... this was not set in my local dev box, causing all tests to pass since assert() was not evaluated.
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| composer config --no-plugins allow-plugins.dealerdirect/phpcodesniffer-composer-installer true |
There was a problem hiding this comment.
I guess this is due to recent changes in Composer.
| run: composer test | ||
|
|
||
| psalm: | ||
| name: Run Psalm |
There was a problem hiding this comment.
I don't think we need to run this in all matrix versions 🌱 . When PHP 7.4 and its available dependencies are fine, the other versions should be as well.
| @@ -24,7 +24,7 @@ | |||
| "friends-of-behat/mink-extension": "^2.5", | |||
| "friends-of-behat/page-object-extension": "^0.3.2", | |||
| "friends-of-behat/service-container-extension": "^1.1", | |||
| "sylius-labs/coding-standard": "^4.1.1", | |||
| "sylius-labs/coding-standard": ">=4.1.1, <=4.2.1", | |||
There was a problem hiding this comment.
They changed something with their config file format, so I had to limit the version range to keep things working over the broad range of PHP versions tested here.
| @@ -48,6 +48,10 @@ Feature: Autowiring contexts | |||
|
|
|||
| App\Tests\SomeContext: | |||
| public: true | |||
|
|
|||
| # https://github.com/symfony/symfony/pull/35879/ | |||
There was a problem hiding this comment.
Addresses a Symfony 5.2 (IIRC?) deprecation + failure as of 6.0.
|
@Yozhef I know you have a lot of other, more important things to worry about 😢 . Maybe if you could approve my workflows to run – this might be an easy merge, and would get the builds back to 🟢 . |
|
Or maybe @pamil you can approve my workflows to run (needs manual approval for first-time contribution). |
|
@mpdude I will look at everything tomorrow and write back. |
|
Thank you @Yozhef! |
This hopefully makes the builds all 🟩 again.
Many changes were necessary to fix the Coding Standards check. See comments below for explanations of particular other changes.