Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add tests, PHPStan and associated fixes #73

Merged
merged 33 commits into from
Oct 22, 2023
Merged

chore: add tests, PHPStan and associated fixes #73

merged 33 commits into from
Oct 22, 2023

Conversation

imorland
Copy link
Member

@imorland imorland commented Oct 21, 2023 •
edited
Loading

Investigating #72

  • Drop support for PHP 7.3 (supported versions are now 7.4, 8.0, 8.1, 8.2)
  • Fix unprotected access to list post reactions api
  • Allow guest permission to be selected for list post reactions
  • Fix session ID not available on some edge cases
  • Reasonable backend test coverage

@imorland imorland linked an issue Oct 21, 2023 that may be closed by this pull request
Unable to react since upgrade to 1.3.0 #72
Closed
@imorland imorland changed the title chore: add tests chore: add tests, PHPStan and associated fixes Oct 21, 2023
@imorland imorland marked this pull request as ready for review October 22, 2023 09:18
@imorland imorland merged commit 156ba9e into master Oct 22, 2023
21 checks passed
@imorland imorland deleted the im/tests branch October 22, 2023 09:21
@deteh deteh mentioned this pull request Oct 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to react since upgrade to 1.3.0
2 participants
@imorland @StyleCIBot