Skip to content

Commit

Permalink
Merge pull request #584 from FriendsOfSymfony/2-to-3
Browse files Browse the repository at this point in the history
2 to 3
  • Loading branch information
dbu authored Aug 2, 2024
2 parents d8a8d8e + 4b53b92 commit 55d84fa
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,19 @@ See also the [GitHub releases page](https://github.com/FriendsOfSymfony/FOSHttpC
2.x
===

2.16.1
2.16.2
------

### Fixed

* The new `EventDispatchingHttpCache::forward` method added in 2.16.0 was not
compatible with Symfony 4.4. Adjusted the signature to make it compatible.

2.16.1
------

(Mistaken tag, same as 2.16.0)

2.16.0
------

Expand Down
2 changes: 1 addition & 1 deletion src/SymfonyCache/EventDispatchingHttpCache.php
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ protected function invalidate(Request $request, bool $catch = false): Response
return parent::invalidate($request, $catch);
}

protected function forward(Request $request, $catch = false, ?Response $entry = null): Response
protected function forward(Request $request, bool $catch = false, ?Response $entry = null): Response
{
// do not abort early, if $entry is set this is a validation request
$this->dispatch(Events::PRE_FORWARD, $request, $entry);
Expand Down

0 comments on commit 55d84fa

Please sign in to comment.