Replace usages of old namespace `Doctrine\Common\Persistence\` with `Doctrine\Persistence\` ("doctrine/persistence" >= 1.3) #3025

phansys · 2021-09-17T22:14:49Z

This change is required in order to fix the class used in the fos_user.object_manager definition.

bin/console lint:container --no-debug

In CheckTypeDeclarationsPass.php line 314:
                                                                               
  Invalid definition for service "fos_user.user_manager": argument 3 of "FOS\  
  UserBundle\Doctrine\UserManager::__construct()" accepts "Doctrine\Persisten  
  ce\ObjectManager", "Doctrine\Common\Persistence\ObjectManager" passed.

Availability of "doctrine/persistence" >= 1.3 is already guaranteed:

FOSUserBundle/composer.json

Line 41 in 813161b

"doctrine/persistence": "<1.3",

See #3000.

…Doctrine\Persistence\` ("doctrine/persistence" >= 1.3)

phansys · 2021-09-24T14:01:00Z

Friendly ping @stof, @nenadalm, @acrobat.

phansys marked this pull request as ready for review September 17, 2021 22:16

Replace usages of old namespace Doctrine\Common\Persistence\ with `…

446c394

…Doctrine\Persistence\` ("doctrine/persistence" >= 1.3)

phansys force-pushed the doctrine_persistence branch from b1632a8 to 446c394 Compare September 17, 2021 22:17

phansys changed the title ~~Fix usages of ObjectManager from "doctrine/persistence" >= 1.3~~ Replace usages of old namespace Doctrine\Common\Persistence\ with Doctrine\Persistence\ ("doctrine/persistence" >= 1.3) Sep 17, 2021

phansys changed the base branch from master to 2.x September 17, 2021 22:23

stof merged commit d2dc95a into FriendsOfSymfony:2.x Sep 24, 2021

phansys deleted the doctrine_persistence branch September 24, 2021 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace usages of old namespace `Doctrine\Common\Persistence\` with `Doctrine\Persistence\` ("doctrine/persistence" >= 1.3) #3025

Replace usages of old namespace `Doctrine\Common\Persistence\` with `Doctrine\Persistence\` ("doctrine/persistence" >= 1.3) #3025

phansys commented Sep 17, 2021 •

edited

Loading

phansys commented Sep 24, 2021

Replace usages of old namespace Doctrine\Common\Persistence\ with Doctrine\Persistence\ ("doctrine/persistence" >= 1.3) #3025

Replace usages of old namespace Doctrine\Common\Persistence\ with Doctrine\Persistence\ ("doctrine/persistence" >= 1.3) #3025

Conversation

phansys commented Sep 17, 2021 • edited Loading

phansys commented Sep 24, 2021

Replace usages of old namespace `Doctrine\Common\Persistence\` with `Doctrine\Persistence\` ("doctrine/persistence" >= 1.3) #3025

Replace usages of old namespace `Doctrine\Common\Persistence\` with `Doctrine\Persistence\` ("doctrine/persistence" >= 1.3) #3025

phansys commented Sep 17, 2021 •

edited

Loading