fix 10.5 compatibility broken in MDEV-19940 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varchar innodb information_schema columns that where effectively boolean got replaced by a int in MDEV-19940 in MariaDB-10.5.0. We use a MariaDB-10.2+ feature EXECUTE IMMEDIATE to form the VIEW expression correctly based on the version. Using EXECUTE IMMEDIATE we've effectively broken <=10.1 compatiblity which is now out of support from MariaDB upstream. closes FromDual#1
grooverdan
added a commit
to grooverdan/MySQLTuner-perl
that referenced
this pull request
Feb 5, 2021
To fix 10.5 compatibility <10.2 compatibility was broken FromDual/mariadb-sys#2 Also only recommend this if the performance schema was compiled in this server version. A recompile the server recommendation would be a bit excessive.
|
note I tried to use executable comment syntax to fix this however ran into MDEV-24795 |
|
Reminder 🏓 |
|
Ping @shinguz |
|
happy belated PR anniversary. |
|
thanks for the fix <3 |
|
@grooverdan thanks also from my side for the fix, this is required for MariaDB usage on Debian/bullseye and your PR works as expected ❤️ |
|
Thanks for your PR, this solved an error while installing the |
|
Thank you so much. This solved my problem while installing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
varchar innodb information_schema columns that where effectively
boolean got replaced by a int in MDEV-19940 in MariaDB-10.5.0.
We use a MariaDB-10.2+ feature EXECUTE IMMEDIATE to form
the VIEW expression correctly based on the version.
Using EXECUTE IMMEDIATE we've effectively broken <=10.1 compatiblity
which is now out of support from MariaDB upstream.
closes #1
I hope this is acceptable @shinguz that provides effective compatibility for supported MariaDB versions.