Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of Option from configs related to regenesis #1668

Closed
xgreenx opened this issue Feb 14, 2024 · 0 comments · Fixed by #1740
Closed

Remove usage of Option from configs related to regenesis #1668

xgreenx opened this issue Feb 14, 2024 · 0 comments · Fixed by #1740
Assignees

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Feb 14, 2024

No description provided.

xgreenx added a commit that referenced this issue Mar 7, 2024
Closes #1668

Removes optional fields from coin and contract configs. 
Added the `CoinConfigGenerator` to enable easier setup of coin configs
for testing. It holds an internal counter that's used to init the
`tx_id` and `output_index`.

A caveat is that we have to be careful when creating coins/contracts in
unit tests. If we use default values for `tx_id` there could be
overlapping utxos and the node setup will fail. Care also needs to be
applied if tests setup configs from multiple sources.

---------

Co-authored-by: xgreenx <xgreenx9999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants