Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove type change on click #107

Merged
merged 22 commits into from
Nov 20, 2023

Conversation

matt-user
Copy link
Contributor

closes FE-27

Copy link

linear bot commented Nov 10, 2023

FE-27 Change addresses component

Currently, the addresses for contracts and accounts change from type to type when we click on it.

Changes that should be done;

  • We should remove the type change on the click.
  • Remove the link from the side of the address to be the address itself, the connection.
  • This should affect all pages and all address types blocks, transactions, and accounts.

Screenshot 2023-11-09 at 2.45.43 PM.png

Copy link
Contributor

github-actions bot commented Nov 10, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from d1b7009

Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add to this links a hover with color primary

@luizstacio
Copy link
Member

Can you also add the hover on the block?
Screenshot 2023-11-13 at 2 09 56 PM

@luizstacio
Copy link
Member

  • When we are rendering a asset_id we don't need to have a link;
Screenshot 2023-11-13 at 2 10 25 PM

Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

not showing sender / recipient anymore

Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size and font weight should be the same of previous versions. It looks a bit bigger and bold now.
Screenshot 2023-11-15 at 8 12 32 PM
Screenshot 2023-11-15 at 8 12 19 PM

luizstacio
luizstacio previously approved these changes Nov 16, 2023
packages/ui/src/components/Copyable/Copyable.tsx Outdated Show resolved Hide resolved
@matt-user matt-user merged commit dd96475 into main Nov 20, 2023
7 checks passed
@matt-user matt-user deleted the matt-user/refactor-address-component branch November 20, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants