Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tx mint custom layout #155

Merged
merged 9 commits into from
Feb 12, 2024
Merged

feat: add tx mint custom layout #155

merged 9 commits into from
Feb 12, 2024

Conversation

pedronauck
Copy link
Contributor

⭐ Closes FE-84

Copy link

linear bot commented Feb 2, 2024

Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think we should keep the same design of the other TX pages, but remove the empty things and add just the Outputs Section. It looks a bit weird with all things as blocks.
  • And add blocks for this other information on the side.
Screenshot 2024-02-01 at 22 08 22

Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new change the script transaction is broken: https://fuel-explorer-c1guco7wj-fuel-labs.vercel.app/tx/0x546ad80a1244efcc41b3e208d0231b4d1c284b0fe776f69a731435cd9a706a86/simple
Screenshot 2024-02-05 at 19 42 00

  1. I think on the mint tx, we could change the title from Outputs to Minted Assets.
  2. We could use the same layout for the outputs, as we have the asset, the to: in this case is the contract and the other infos could be bellow it.
Screenshot 2024-02-05 at 19 43 13

Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedronauck pedronauck merged commit e7ecb7f into main Feb 12, 2024
6 checks passed
@pedronauck pedronauck deleted the pn/chore/mint-tx branch February 12, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants