Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

chore: add executor metrics #1456

Merged
merged 3 commits into from
Nov 9, 2023
Merged

chore: add executor metrics #1456

merged 3 commits into from
Nov 9, 2023

Conversation

ra0x3
Copy link
Contributor

@ra0x3 ra0x3 commented Nov 7, 2023

Thanks for opening a PR with the Fuel Indexer project. Please review the Checklist below and ensure you've completed all of the necessary steps to make this PR review as painless as possible.

Checklist

  • Ensure your top-level commit message is in line with our contributor guidelines.
  • Please add proper labels.
  • If there is an issue associated with this PR, please link the issue (right-hand sidebar)
  • If there is not an issue associated with this PR, add this PR to the "Fuel Indexer" project (right-hand sidebar)
  • Please allow Codeowners at least 24 hours to do a first-pass review.
  • Please add thoroughly detailed testing steps below.
  • Please keep your Changelog message short and sweet.

Description

  • PR adds a few metrics to the executor.
  • Might have to add more later, but want to see how these do for now

Testing steps

  • Start the service on beta-4 cargo run --bin fuel-indexer -- run --run-migrations --fuel-node-host beta-4.fuel.network --fuel-node-port 80
  • Deploy the hello-world indexer forc index deploy --path examples/hello-world/hello-world
  • View the new metrics curl http://localhost:29987/api/metrics
  • Should see the new metrics
# EOF
# HELP executor_handler_operation_duration .
# TYPE executor_handler_operation_duration histogram
executor_handler_operation_duration_sum{path="fuellabs.hello_world"} 1071.0
executor_handler_operation_duration_count{path="fuellabs.hello_world"} 35
executor_handler_operation_duration_bucket{le="0.0",path="fuellabs.hello_world"} 0
executor_handler_operation_duration_bucket{le="10.0",path="fuellabs.hello_world"} 0
executor_handler_operation_duration_bucket{le="100.0",path="fuellabs.hello_world"} 35
executor_handler_operation_duration_bucket{le="1000.0",path="fuellabs.hello_world"} 35
executor_handler_operation_duration_bucket{le="10000.0",path="fuellabs.hello_world"} 35
executor_handler_operation_duration_bucket{le="50000.0",path="fuellabs.hello_world"} 35
executor_handler_operation_duration_bucket{le="100000.0",path="fuellabs.hello_world"} 35
executor_handler_operation_duration_bucket{le="500000.0",path="fuellabs.hello_world"} 35
executor_handler_operation_duration_bucket{le="1000000.0",path="fuellabs.hello_world"} 35
executor_handler_operation_duration_bucket{le="+Inf",path="fuellabs.hello_world"} 35
# EOF
# HELP executor_web_request_duration .
# TYPE executor_web_request_duration histogram
executor_web_request_duration_sum{path="fuellabs.hello_world"} 3164.0
executor_web_request_duration_count{path="fuellabs.hello_world"} 35
executor_web_request_duration_bucket{le="0.0",path="fuellabs.hello_world"} 0
executor_web_request_duration_bucket{le="10.0",path="fuellabs.hello_world"} 0
executor_web_request_duration_bucket{le="100.0",path="fuellabs.hello_world"} 28
executor_web_request_duration_bucket{le="1000.0",path="fuellabs.hello_world"} 35
executor_web_request_duration_bucket{le="10000.0",path="fuellabs.hello_world"} 35
executor_web_request_duration_bucket{le="50000.0",path="fuellabs.hello_world"} 35
executor_web_request_duration_bucket{le="100000.0",path="fuellabs.hello_world"} 35
executor_web_request_duration_bucket{le="500000.0",path="fuellabs.hello_world"} 35
executor_web_request_duration_bucket{le="1000000.0",path="fuellabs.hello_world"} 35
executor_web_request_duration_bucket{le="+Inf",path="fuellabs.hello_world"} 35
# EOF

Changelog

  • chore: add executor metrics

@ra0x3 ra0x3 self-assigned this Nov 7, 2023
@ra0x3 ra0x3 linked an issue Nov 7, 2023 that may be closed by this pull request
4 tasks
@ra0x3 ra0x3 force-pushed the rashad/1445-add-more-metrics branch from 2eef41f to 12f82a8 Compare November 7, 2023 18:11
@ra0x3 ra0x3 marked this pull request as ready for review November 7, 2023 18:19
Copy link
Contributor

@lostman lostman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll run the testing steps first thing tomorrow morning. Right now I only have a small change request.

packages/fuel-indexer/src/executor.rs Outdated Show resolved Hide resolved
packages/fuel-indexer/src/executor.rs Outdated Show resolved Hide resolved
@ra0x3 ra0x3 requested a review from lostman November 8, 2023 15:16
@ra0x3 ra0x3 merged commit 98cb9a3 into develop Nov 9, 2023
18 checks passed
@ra0x3 ra0x3 deleted the rashad/1445-add-more-metrics branch November 9, 2023 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more metrics reporting to the service
2 participants