Some clarification after implementation #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
previously approved these changes
Nov 8, 2023
MitchTurner
previously approved these changes
Nov 8, 2023
Voxelot
reviewed
Nov 8, 2023
Voxelot
reviewed
Nov 8, 2023
| | `outputs` | [Output](./output.md)`[]` | List of outputs. | | ||
| | `witnesses` | [Witness](./witness.md)`[]` | List of witnesses. | | ||
|
|
||
| Given helper `max_gas()` returns the maximum gas that the transaction can use. |
There was a problem hiding this comment.
Do we define max_gas() anywhere? It might be confusing without more context. i.e in tx-validity
There was a problem hiding this comment.
I think it is what you've started in the #529 =D I decided not to describe it here because we have another PR dedicated to the gas model description.
MitchTurner
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Findings after implementation FuelLabs/fuel-vm#623