Split ArithmeticError into more granular errors #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
added
breaking
# Conflicts: # CHANGELOG.md # fuel-asm/src/panic_reason.rs # fuel-tx/src/transaction/validity/error.rs # fuel-vm/src/checked_transaction.rs # fuel-vm/src/checked_transaction/balances.rs # fuel-vm/src/interpreter.rs # fuel-vm/src/interpreter/balances.rs
xgreenx
approved these changes
Nov 9, 2023
Merged
xgreenx
added a commit
to FuelLabs/fuel-core
that referenced
this pull request
Nov 20, 2023
Closes #1414. Also does some upgrades for latest `fuel-vm` version. Targets FuelLabs/fuel-vm#625 currently, needs new `fuel-vm` release after that is merged. This also mostly reverts #1457 which was not working correctly, especially with regards to `call` instruction. --------- Co-authored-by: xgreenx <xgreenx9999@gmail.com>
crypto523
added a commit
to crypto523/fuel-core
that referenced
this pull request
Oct 7, 2024
Closes FuelLabs/fuel-core#1414. Also does some upgrades for latest `fuel-vm` version. Targets FuelLabs/fuel-vm#625 currently, needs new `fuel-vm` release after that is merged. This also mostly reverts FuelLabs/fuel-core#1457 which was not working correctly, especially with regards to `call` instruction. --------- Co-authored-by: xgreenx <xgreenx9999@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ArithmeticErroronly for arithmetic operations, and introduce new errors likeBalanceOverflowfor others. Whenever an error is internally caused by a type conversion tousize, so that an overflowing value wouldn't map to a valid index anyway, return the missing item error instead.